foster/denoland-rusty-v8
0
0
Fork 0
mirror of https://github.com/denoland/rusty_v8.git synced 2024-11-21 15:04:33 -05:00
Code Issues Activity

fix: fix size checking on 32-bit platforms (#1489)

Browse source 
fix size checking on 32-bit platforms on 32-bit platforms like armv7 or
ppc32, the size of `v8::ScriptCompiler::CompilationDetails` and
`v8::ScriptCompiler::Source` will be different than currently expected.
This is due to how those 32-bit platforms layout the 64-bit elements in
a structure.
This commit is contained in:
liushuyu 2024-05-29 08:32:50 -06:00 committed by GitHub
parent 6dc819bba1
commit 3b4ecfdc6f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 28 additions and 29 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

57
src/binding.cc
View file

@ -59,12 +59,15 @@ static_assert(sizeof(v8::PromiseRejectMessage) == sizeof(size_t) * 3,
static_assert(sizeof(v8::Locker) == sizeof(size_t) * 2, "Locker size mismatch");
static_assert(sizeof(v8::ScriptCompiler::CompilationDetails) ==
sizeof(size_t) * 3,
sizeof(int64_t) * 3,
"CompilationDetails size mismatch");
static_assert(
sizeof(v8::ScriptCompiler::Source) ==
align_to<size_t>(sizeof(size_t) * 9 + sizeof(int) * 2 +
align_to<size_t>(sizeof(size_t) * 8 + sizeof(int) * 2 +
// the last field before CompilationDetails on 32-bit
// systems will have a padding
align_to<int64_t>(sizeof(size_t)) +
sizeof(v8::ScriptCompiler::CompilationDetails)),
"Source size mismatch");
@ -278,8 +281,9 @@ bool v8__Isolate__AddMessageListener(v8::Isolate* isolate,
return isolate->AddMessageListener(callback);
}
bool v8__Isolate__AddMessageListenerWithErrorLevel(
v8::Isolate* isolate, v8::MessageCallback callback, int error_level) {
bool v8__Isolate__AddMessageListenerWithErrorLevel(v8::Isolate* isolate,
v8::MessageCallback callback,
int error_level) {
return isolate->AddMessageListenerWithErrorLevel(callback, error_level);
}
@ -362,13 +366,10 @@ size_t v8__Isolate__CreateParams__SIZEOF() {
}
void v8__Isolate__DateTimeConfigurationChangeNotification(
v8::Isolate* isolate,
v8::Isolate::TimeZoneDetection time_zone_detection
) {
isolate->DateTimeConfigurationChangeNotification(time_zone_detection);
v8::Isolate* isolate, v8::Isolate::TimeZoneDetection time_zone_detection) {
isolate->DateTimeConfigurationChangeNotification(time_zone_detection);
}
void v8__ResourceConstraints__ConfigureDefaultsFromHeapSize(
v8::ResourceConstraints* constraints, size_t initial_heap_size_in_bytes,
size_t maximum_heap_size_in_bytes) {
@ -1049,12 +1050,13 @@ int v8__String__WriteUtf8(const v8::String& self, v8::Isolate* isolate,
}
const v8::String::ExternalStringResource* v8__String__GetExternalStringResource(
const v8::String& self) {
const v8::String& self) {
return self.GetExternalStringResource();
}
const v8::String::ExternalStringResourceBase* v8__String__GetExternalStringResourceBase(
const v8::String& self, v8::String::Encoding* encoding_out) {
const v8::String::ExternalStringResourceBase*
v8__String__GetExternalStringResourceBase(const v8::String& self,
v8::String::Encoding* encoding_out) {
return self.GetExternalStringResourceBase(encoding_out);
}
@ -1219,19 +1221,16 @@ void v8__ObjectTemplate__SetInternalFieldCount(const v8::ObjectTemplate& self,
}
void v8__ObjectTemplate__SetNativeDataProperty(
const v8::ObjectTemplate& self,
const v8::Name& key,
v8::AccessorNameGetterCallback getter,
v8::AccessorNameSetterCallback setter,
const v8::Value* data_or_null,
v8::PropertyAttribute attr) {
ptr_to_local(&self)->SetNativeDataProperty(ptr_to_local(&key),
getter, setter, ptr_to_local(data_or_null), attr);
const v8::ObjectTemplate& self, const v8::Name& key,
v8::AccessorNameGetterCallback getter,
v8::AccessorNameSetterCallback setter, const v8::Value* data_or_null,
v8::PropertyAttribute attr) {
ptr_to_local(&self)->SetNativeDataProperty(ptr_to_local(&key), getter, setter,
ptr_to_local(data_or_null), attr);
}
void v8__ObjectTemplate__SetNamedPropertyHandler(
const v8::ObjectTemplate& self,
v8::NamedPropertyGetterCallback getter,
const v8::ObjectTemplate& self, v8::NamedPropertyGetterCallback getter,
v8::NamedPropertySetterCallback setter,
v8::NamedPropertyQueryCallback query,
v8::NamedPropertyDeleterCallback deleter,
@ -1530,9 +1529,9 @@ const v8::Value* v8__Object__GetOwnPropertyDescriptor(
ptr_to_local(&context), ptr_to_local(&key)));
}
const v8::Value* v8__Object__GetRealNamedProperty(
const v8::Object& self, const v8::Context& context, const v8::Name& key) {
const v8::Value* v8__Object__GetRealNamedProperty(const v8::Object& self,
const v8::Context& context,
const v8::Name& key) {
return maybe_local_to_ptr(ptr_to_local(&self)->GetRealNamedProperty(
ptr_to_local(&context), ptr_to_local(&key)));
}
@ -1934,8 +1933,8 @@ const v8::Value* v8__Context__GetContinuationPreservedEmbedderData(
return local_to_ptr(value);
}
v8::MicrotaskQueue* v8__MicrotaskQueue__New(
v8::Isolate* isolate, v8::MicrotasksPolicy policy) {
v8::MicrotaskQueue* v8__MicrotaskQueue__New(v8::Isolate* isolate,
v8::MicrotasksPolicy policy) {
return v8::MicrotaskQueue::New(isolate, policy).release();
}
@ -3337,7 +3336,7 @@ struct v8__ValueSerializer__Delegate : public v8::ValueSerializer::Delegate {
}
v8::Maybe<bool> IsHostObject(v8::Isolate* isolate,
v8::Local<v8::Object> object) override {
v8::Local<v8::Object> object) override {
return maybe_bool_to_maybe(
v8__ValueSerializer__Delegate__IsHostObject(this, isolate, object));
}
@ -3753,7 +3752,7 @@ v8::CppHeap* cppgc__heap__create(v8::Platform* platform,
return heap.release();
}
void v8__Isolate__AttachCppHeap(v8::Isolate* isolate, v8::CppHeap* cpp_heap) {
void v8__Isolate__AttachCppHeap(v8::Isolate* isolate, v8::CppHeap* cpp_heap) {
// The AttachCppHeap method is deprecated but the alternative of passing
// heap to the Isolate CreateParams is broken.
//