foster/denoland-rusty-v8
0
0
Fork 0
mirror of https://github.com/denoland/rusty_v8.git synced 2025-01-12 17:09:28 -05:00
Code Issues Activity

minor clean ups

Browse source
This commit is contained in:
Ryan Dahl 2019-11-30 09:16:25 -08:00 committed by Ry Dahl
parent 0a256461e2
commit 517c213f1e
2 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/V8.rs
View file

@ -79,6 +79,7 @@ pub fn set_flags_from_command_line(args: Vec<String>) -> Vec<String> {
.collect() .collect()
} }
#[test]
fn test_set_flags_from_command_line() { fn test_set_flags_from_command_line() {
let r = set_flags_from_command_line(vec![ let r = set_flags_from_command_line(vec![
"binaryname".to_string(), "binaryname".to_string(),
@ -106,6 +107,8 @@ fn test_get_version() {
// TODO: V8::InitializePlatform does not actually take a UniquePtr but rather // TODO: V8::InitializePlatform does not actually take a UniquePtr but rather
// a raw pointer. This means that the Platform object is not released when // a raw pointer. This means that the Platform object is not released when
// V8::ShutdownPlatform is called. // V8::ShutdownPlatform is called.
/// Sets the v8::Platform to use. This should be invoked before V8 is
/// initialized.
pub fn initialize_platform(platform: UniquePtr<Platform>) { pub fn initialize_platform(platform: UniquePtr<Platform>) {
let mut global_state_guard = GLOBAL_STATE.lock().unwrap(); let mut global_state_guard = GLOBAL_STATE.lock().unwrap();
assert_eq!(*global_state_guard, Uninitialized); assert_eq!(*global_state_guard, Uninitialized);
@ -142,6 +145,8 @@ pub unsafe fn dispose() -> bool {
true true
} }
/// Clears all references to the v8::Platform. This should be invoked after
/// V8 was disposed.
pub fn shutdown_platform() { pub fn shutdown_platform() {
let mut global_state_guard = GLOBAL_STATE.lock().unwrap(); let mut global_state_guard = GLOBAL_STATE.lock().unwrap();
assert_eq!(*global_state_guard, Disposed); assert_eq!(*global_state_guard, Disposed);

3
src/isolate.rs
View file

@ -4,7 +4,6 @@ use crate::array_buffer::Allocator;
use crate::support::Delete; use crate::support::Delete;
use crate::support::Opaque; use crate::support::Opaque;
use crate::support::UniqueRef; use crate::support::UniqueRef;
use crate::V8::assert_initialized;
extern "C" { extern "C" {
fn v8__Isolate__New(params: *mut CreateParams) -> &'static mut CxxIsolate; fn v8__Isolate__New(params: *mut CreateParams) -> &'static mut CxxIsolate;
@ -31,7 +30,7 @@ pub struct Isolate(&'static mut CxxIsolate);
impl Isolate { impl Isolate {
pub fn new(params: UniqueRef<CreateParams>) -> Self { pub fn new(params: UniqueRef<CreateParams>) -> Self {
// TODO: support CreateParams. // TODO: support CreateParams.
assert_initialized(); crate::V8::assert_initialized();
Self(unsafe { v8__Isolate__New(params.into_raw()) }) Self(unsafe { v8__Isolate__New(params.into_raw()) })
} }
} }