chore: upgrade Rust to 1.57.0 (#856)

.github/workflows/ci.yml

@@ -70,7 +70,7 @@ jobs:
         uses: hecrj/setup-rust-action@v1
         with:
           components: clippy, rustfmt
-          rust-version: 1.56.1
+          rust-version: 1.57.0
 
       - name: Install python
         uses: actions/setup-python@v2
@@ -117,7 +117,6 @@ jobs:
           restore-keys:
             cargo-${{ matrix.config.target }}-${{ matrix.config.variant }}-
 
-
         # It seems that the 'target' directory does not always get restored
         # from cache correctly on MacOS. In the build log we see the following:
         #
@@ -159,7 +158,6 @@ jobs:
           . $basename/sccache --start-server
           echo "$(pwd)/$basename" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
 
-
       - name: Test
         run:
           cargo test -vv --all-targets --locked ${{ env.CARGO_VARIANT_FLAG }}

rust-toolchain

@@ -1 +1 @@
-1.56.1
+1.57.0

src/scope.rs

@@ -111,7 +111,7 @@ use crate::Value;
 /// and run is compiled and run in this context.
 #[derive(Debug)]
 pub struct ContextScope<'s, P> {
-  data: NonNull<data::ScopeData>,
+  _data: NonNull<data::ScopeData>,
   _phantom: PhantomData<&'s mut P>,
 }
 
@@ -146,7 +146,7 @@ impl<'s, P: param::NewContextScope<'s>> ContextScope<'s, P> {
 /// for which the handle scope has been deleted is undefined.
 #[derive(Debug)]
 pub struct HandleScope<'s, C = Context> {
-  data: NonNull<data::ScopeData>,
+  _data: NonNull<data::ScopeData>,
   _phantom: PhantomData<&'s mut C>,
 }
 
@@ -293,7 +293,7 @@ impl<'s> HandleScope<'s> {
 // at all. These tests need to updated first.
 #[derive(Debug)]
 pub struct EscapableHandleScope<'s, 'e: 's, C = Context> {
-  data: NonNull<data::ScopeData>,
+  _data: NonNull<data::ScopeData>,
   _phantom:
     PhantomData<(&'s mut raw::HandleScope, &'e mut raw::EscapeSlot, &'s C)>,
 }
@@ -329,7 +329,7 @@ impl<'s, 'e: 's, C> EscapableHandleScope<'s, 'e, C> {
 /// An external exception handler.
 #[derive(Debug)]
 pub struct TryCatch<'s, P> {
-  data: NonNull<data::ScopeData>,
+  _data: NonNull<data::ScopeData>,
   _phantom: PhantomData<&'s mut P>,
 }
 
@@ -508,7 +508,7 @@ where
 ///   - `&PromiseRejectMessage`
 #[derive(Debug)]
 pub struct CallbackScope<'s, C = Context> {
-  data: NonNull<data::ScopeData>,
+  _data: NonNull<data::ScopeData>,
   _phantom: PhantomData<&'s mut HandleScope<'s, C>>,
 }
 
@@ -1034,7 +1034,7 @@ pub(crate) mod data {
       self.new_scope_data_with(move |data| {
         data.scope_type_specific_data.init_with(|| {
           ScopeTypeSpecificData::ContextScope {
-            raw_context_scope: raw::ContextScope::new(context),
+            _raw_context_scope: raw::ContextScope::new(context),
           }
         });
         data.context.set(Some(context.as_non_null()));
@@ -1446,7 +1446,7 @@ pub(crate) mod data {
   enum ScopeTypeSpecificData {
     None,
     ContextScope {
-      raw_context_scope: raw::ContextScope,
+      _raw_context_scope: raw::ContextScope,
     },
     HandleScope {
       raw_handle_scope: raw::HandleScope,

tests/compile_fail/handle_scope_escape_to_nowhere.stderr

@@ -2,7 +2,9 @@ error[E0277]: the trait bound `OwnedIsolate: v8::scope::param::NewEscapableHandl
    --> $DIR/handle_scope_escape_to_nowhere.rs:5:50
     |
 5   |   let mut _scope = v8::EscapableHandleScope::new(&mut isolate);
-    |                                                  ^^^^^^^^^^^^ the trait `v8::scope::param::NewEscapableHandleScope<'_, '_>` is not implemented for `OwnedIsolate`
+    |                    ----------------------------- ^^^^^^^^^^^^ the trait `v8::scope::param::NewEscapableHandleScope<'_, '_>` is not implemented for `OwnedIsolate`
+    |                    |
+    |                    required by a bound introduced by this call
     |
 note: required by `EscapableHandleScope::<'s, 'e>::new`
    --> $DIR/scope.rs:303:3

tests/test_api.rs

@@ -469,7 +469,7 @@ fn get_isolate_from_handle() {
   check_handle(scope, Some(true), |s| v8::String::new(s, "Words").unwrap());
   check_eval(scope, Some(true), "'Hello'");
   check_eval(scope, Some(true), "Symbol()");
-  check_handle(scope, Some(true), |s| v8::Object::new(s));
+  check_handle(scope, Some(true), v8::Object::new);
   check_eval(scope, Some(true), "this");
   check_handle(scope, Some(true), |s| s.get_current_context());
   check_eval(scope, Some(true), "({ foo: 'bar' })");