0
0
Fork 0
mirror of https://github.com/denoland/rusty_v8.git synced 2024-11-21 15:04:33 -05:00

clean up (#3)

Use .cc instead of .cpp
This commit is contained in:
Ry Dahl 2019-11-01 00:54:54 -04:00 committed by GitHub
parent ae7809136d
commit 7846160a63
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 7 additions and 15 deletions

View file

@ -87,3 +87,5 @@ jobs:
run: |
rustup component add clippy
cargo clippy --all-targets --release --locked -- -D clippy::all
# TODO cpplint

View file

@ -3,10 +3,10 @@ import("//third_party/v8/gni/v8.gni")
v8_static_library("rusty_v8") {
sources = [
"src/inspector/channel.cpp",
"src/inspector/client.cpp",
"src/platform/task.cpp",
"src/string_buffer.cpp",
"src/inspector/channel.cc",
"src/inspector/client.cc",
"src/platform/task.cc",
"src/string_buffer.cc",
]
deps = [
"//build/config:shared_library_deps",

View file

@ -43,15 +43,6 @@ fn main() {
}
}
// TODO(ry) Remove
fn disable_depot_tools_update() {
Command::new("python")
.arg("third_party/depot_tools/update_depot_tools_toggle.py")
.arg("--disable")
.status()
.expect("update_depot_tools_toggle.py failed");
}
fn git_submodule_update() {
println!("cargo:warning=Running git submodule update");
Command::new("git")
@ -70,8 +61,6 @@ fn gclient_sync() {
if !third_party.join(&gclient_rel).exists() {
git_submodule_update();
}
disable_depot_tools_update();
// Command::new(gclient config http://src.chromium.org/svn/trunk/src
println!(
"cargo:warning=Running gclient sync to download V8. This could take a while."
@ -97,6 +86,7 @@ fn gclient_sync() {
fn cc_wrapper(gn_args: &mut Vec<String>, sccache_path: &Path) {
gn_args.push(format!("cc_wrapper={:?}", sccache_path));
// Disable treat_warnings_as_errors until this sccache bug is fixed:
// https://github.com/mozilla/sccache/issues/264
if cfg!(target_os = "windows") {