foster/denoland-rusty-v8
0
0
Fork 0
mirror of https://github.com/denoland/rusty_v8.git synced 2025-01-14 10:02:09 -05:00
Code Issues Activity

Add more comments explaining why Local::from_raw() is appropriate (#389)

Browse source
This commit is contained in:
Bert Belder 2020-05-31 19:22:08 +02:00
parent 25276c8249
commit a9ea69b5d5
No known key found for this signature in database
GPG key ID: 7A77887B2E2ED461
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/script_or_module.rs
View file

@ -18,6 +18,9 @@ impl ScriptOrModule {
/// The name that was passed by the embedder as ResourceName to the
/// ScriptOrigin. This can be either a v8::String or v8::Undefined.
pub fn get_resource_name(&self) -> Local<Value> {
// Note: the C++ `v8::ScriptOrModule::GetResourceName()` does not actually
// return a local handle, but rather a handle whose lifetime is bound to
// the related `ScriptOrModule` object.
unsafe {
let ptr = v8__ScriptOrModule__GetResourceName(self);
Local::from_raw(ptr).unwrap()
@ -27,6 +30,9 @@ impl ScriptOrModule {
/// The options that were passed by the embedder as HostDefinedOptions to the
/// ScriptOrigin.
pub fn get_host_defined_options(&self) -> Local<PrimitiveArray> {
// Note: the C++ `v8::ScriptOrModule::GetHostDefinedOptions()` does not
// actually return a local handle, but rather a handle whose lifetime is
// bound to the related `ScriptOrModule` object.
unsafe {
let ptr = v8__ScriptOrModule__GetHostDefinedOptions(self);
Local::from_raw(ptr).unwrap()