foster/denoland-rusty-v8
0
0
Fork 0
mirror of https://github.com/denoland/rusty_v8.git synced 2024-11-21 15:04:33 -05:00
Code Issues Activity

Uncomment broken test, use #[ignore] instead (#388)

Browse source
This commit is contained in:
Bert Belder 2020-05-31 18:46:24 +02:00
parent cfbfb9524f
commit af9ac3c4b9
No known key found for this signature in database
GPG key ID: 7A77887B2E2ED461
1 changed files with 14 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
tests/test_api.rs
View file

@ -76,22 +76,20 @@ fn handle_scope_numbers() {
// `Local<Integer>` created at the end of the test is created in HandleScope
// `hs2` and not in `hs1` as specified. When this local is accessed, which is
// after `hs2` is destroyed, a crash happens.
// #[test]
// fn handle_scope_early_drop() {
// let _setup_guard = setup();
//
// let mut isolate = v8::Isolate::new(Default::default());
// let mut hs1 = v8::HandleScope::new(&mut isolate);
// let hs1 = hs1.enter();
//
// let local = {
// let mut hs2 = v8::HandleScope::new(hs1);
// let _hs2 = hs2.enter();
//
// v8::Integer::new(hs1, 123)
// };
// assert_eq!(local.value(), 123);
// }
#[test]
#[ignore]
fn handle_scope_early_drop() {
let _setup_guard = setup();
let mut isolate = v8::Isolate::new(Default::default());
let mut hs1 = v8::HandleScope::new(&mut isolate);
let hs1 = hs1.enter();
let local = {
let mut hs2 = v8::HandleScope::new(hs1);
let _hs2 = hs2.enter();
v8::Integer::new(hs1, 123)
};
assert_eq!(local.value(), 123);
}
#[test]
fn global_handles() {