foster/denoland-rusty-v8
0
0
Fork 0
mirror of https://github.com/denoland/rusty_v8.git synced 2025-01-12 00:54:15 -05:00
Code Issues Activity

Work around a bug in the V8 headers (#463)

Browse source
This commit is contained in:
Bert Belder 2020-09-09 11:57:58 +02:00
parent 3b27748a17
commit b3f9cb1f01
No known key found for this signature in database
GPG key ID: 7A77887B2E2ED461
1 changed files with 20 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/support.h
View file

@ -11,6 +11,26 @@
#include "v8/include/v8.h" #include "v8/include/v8.h"
// Work around a bug in the V8 headers.
//
// The following template is defined in v8-internal.h. It has a subtle bug that
// indirectly makes it impossible to convert `v8::Data` handles to themselves.
// Some methods do that impliclity so they don't compile without this hack; one
// example is `Local<Data> MaybeLocal::FromMaybe(Local<Data> default_value)`.
//
// Spot the bug :)
//
// ```
// template <class T>
// V8_INLINE void PerformCastCheck(T* data) {
// CastCheck<std::is_base_of<Data, T>::value &&
// !std::is_same<Data, std::remove_cv<T>>::value>::Perform(data);
// }
// ```
template <>
template <>
inline void v8::internal::CastCheck<true>::Perform<v8::Data>(v8::Data* data) {}
// Check assumptions made in binding code. // Check assumptions made in binding code.
static_assert(sizeof(bool) == sizeof(uint8_t), ""); static_assert(sizeof(bool) == sizeof(uint8_t), "");
static_assert(sizeof(std::unique_ptr<void>) == sizeof(void*), ""); static_assert(sizeof(std::unique_ptr<void>) == sizeof(void*), "");