From fb19eecc3151e80b4f0f623c318cce56de638ac6 Mon Sep 17 00:00:00 2001
From: Bert Belder <bertbelder@gmail.com>
Date: Fri, 17 Jan 2020 08:34:48 +0100
Subject: [PATCH] Rename new_null() to null() and new_undefined() to
 undefined() (#216)

This is more consistent with V8's C++ API.
---
 src/primitives.rs | 7 ++-----
 tests/test_api.rs | 8 ++++----
 2 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/src/primitives.rs b/src/primitives.rs
index d557df3d..263c0e22 100644
--- a/src/primitives.rs
+++ b/src/primitives.rs
@@ -6,20 +6,17 @@ use crate::ToLocal;
 
 extern "C" {
   fn v8__Null(isolate: *mut Isolate) -> *mut Primitive;
-
   fn v8__Undefined(isolate: *mut Isolate) -> *mut Primitive;
 
   fn v8__Boolean__New(isolate: *mut Isolate, value: bool) -> *mut Boolean;
 }
 
-pub fn new_null<'sc>(scope: &mut impl ToLocal<'sc>) -> Local<'sc, Primitive> {
+pub fn null<'sc>(scope: &mut impl ToLocal<'sc>) -> Local<'sc, Primitive> {
   let ptr = unsafe { v8__Null(scope.isolate()) };
   unsafe { scope.to_local(ptr) }.unwrap()
 }
 
-pub fn new_undefined<'sc>(
-  scope: &mut impl ToLocal<'sc>,
-) -> Local<'sc, Primitive> {
+pub fn undefined<'sc>(scope: &mut impl ToLocal<'sc>) -> Local<'sc, Primitive> {
   let ptr = unsafe { v8__Undefined(scope.isolate()) };
   unsafe { scope.to_local(ptr) }.unwrap()
 }
diff --git a/tests/test_api.rs b/tests/test_api.rs
index 6fdf98bd..df921ab4 100644
--- a/tests/test_api.rs
+++ b/tests/test_api.rs
@@ -763,12 +763,12 @@ fn test_primitives() {
   {
     let mut hs = v8::HandleScope::new(&mut locker);
     let scope = hs.enter();
-    let null = v8::new_null(scope);
+    let null = v8::null(scope);
     assert!(!null.is_undefined());
     assert!(null.is_null());
     assert!(null.is_null_or_undefined());
 
-    let undefined = v8::new_undefined(scope);
+    let undefined = v8::undefined(scope);
     assert!(undefined.is_undefined());
     assert!(!undefined.is_null());
     assert!(undefined.is_null_or_undefined());
@@ -894,7 +894,7 @@ fn object() {
     let scope = hs.enter();
     let mut context = v8::Context::new(scope);
     context.enter();
-    let null: v8::Local<v8::Value> = v8::new_null(scope).into();
+    let null: v8::Local<v8::Value> = v8::null(scope).into();
     let s1 = v8::String::new(scope, "a").unwrap();
     let s2 = v8::String::new(scope, "b").unwrap();
     let name1 = s1.into();
@@ -2034,7 +2034,7 @@ fn try_from_local() {
     context.enter();
 
     {
-      let value: v8::Local<v8::Value> = v8::new_undefined(scope).into();
+      let value: v8::Local<v8::Value> = v8::undefined(scope).into();
       let _primitive = v8::Local::<v8::Primitive>::try_from(value).unwrap();
       assert_eq!(
         v8::Local::<v8::Object>::try_from(value)