From fe298359d9e4513994cc62963d7bdcd498992fda Mon Sep 17 00:00:00 2001
From: Ryan Dahl <ry@tinyclouds.org>
Date: Tue, 15 Jun 2021 11:12:23 -0400
Subject: [PATCH] Upgrade V8 to 9.2.230.10 (#700)

* We are floating a revert of v8/v8@7f9d7f0 because of the issue described in #694.
* Upgrade ICU 68 -> 69
* Upgrade //build and //buildtools
* set v8_enable_shared_ro_heap = false to fix tests
---
 .gitmodules     | 2 +-
 .gn             | 6 ++++++
 README.md       | 2 +-
 build           | 2 +-
 buildtools      | 2 +-
 src/icu.rs      | 4 ++--
 third_party/icu | 2 +-
 v8              | 2 +-
 8 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/.gitmodules b/.gitmodules
index ba21b85e..4d712d7e 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -1,6 +1,6 @@
 [submodule "v8"]
 	path = v8
-	url = https://chromium.googlesource.com/v8/v8
+	url = https://github.com/denoland/v8.git
 [submodule "build"]
 	path = build
 	url = https://github.com/denoland/chromium_build.git
diff --git a/.gn b/.gn
index a39c5b73..5e758170 100644
--- a/.gn
+++ b/.gn
@@ -23,6 +23,12 @@ default_args = {
   use_dummy_lastchange = true
   treat_warnings_as_errors = true
 
+  # To avoid test failure:
+  # Fatal error in ../../../v8/src/heap/read-only-spaces.cc, line 69
+  # Check failed: read_only_blob_checksum_ == snapshot_checksum (<unprintable>
+  # vs. 604745897).
+  v8_enable_shared_ro_heap = false
+
   # TODO(ry) remove
   v8_imminent_deprecation_warnings = false
 
diff --git a/README.md b/README.md
index ba3fc221..5cd5a78c 100644
--- a/README.md
+++ b/README.md
@@ -1,6 +1,6 @@
 # Rusty V8 Binding
 
-V8 Version: 9.1.269.35
+V8 Version: 9.2.230.10
 
 [![ci](https://github.com/denoland/rusty_v8/workflows/ci/badge.svg?branch=main)](https://github.com/denoland/rusty_v8/actions)
 [![crates](https://img.shields.io/crates/v/rusty_v8.svg)](https://crates.io/crates/rusty_v8)
diff --git a/build b/build
index e10aa6b4..b1cbcbce 160000
--- a/build
+++ b/build
@@ -1 +1 @@
-Subproject commit e10aa6b45bd82ec89d827724d1074058a28ba04a
+Subproject commit b1cbcbce2c71b08bb34ede6add332626e78fa10e
diff --git a/buildtools b/buildtools
index ccba851a..3655cd61 160000
--- a/buildtools
+++ b/buildtools
@@ -1 +1 @@
-Subproject commit ccba851a7a7cdbbfa4e15c738147565b4936f438
+Subproject commit 3655cd61062a8e8282d2d01df0a19aae410d336d
diff --git a/src/icu.rs b/src/icu.rs
index e478e6df..ded9ca76 100644
--- a/src/icu.rs
+++ b/src/icu.rs
@@ -1,5 +1,5 @@
 extern "C" {
-  fn udata_setCommonData_68(this: *const u8, error_code: *mut i32);
+  fn udata_setCommonData_69(this: *const u8, error_code: *mut i32);
 }
 
 /// This function bypasses the normal ICU data loading process and allows you to force ICU's system
@@ -38,7 +38,7 @@ extern "C" {
 pub fn set_common_data(data: &'static [u8]) -> Result<(), i32> {
   let mut error_code = 0i32;
   unsafe {
-    udata_setCommonData_68(data.as_ptr(), &mut error_code);
+    udata_setCommonData_69(data.as_ptr(), &mut error_code);
   }
   if error_code == 0 {
     Ok(())
diff --git a/third_party/icu b/third_party/icu
index 28b0e9ea..f022e298 160000
--- a/third_party/icu
+++ b/third_party/icu
@@ -1 +1 @@
-Subproject commit 28b0e9ea59878fdd1682593be2ac489a6a6bbb21
+Subproject commit f022e298b4f4a782486bb6d5ce6589c998b51fe2
diff --git a/v8 b/v8
index 399148d0..b7957d8d 160000
--- a/v8
+++ b/v8
@@ -1 +1 @@
-Subproject commit 399148d00a4fcdab96baa1c8e9d9346a78d4e339
+Subproject commit b7957d8daf01303e002a13816cd40db41fb97498