mirror of
https://github.com/denoland/rusty_v8.git
synced 2025-01-13 17:40:23 -05:00
6ac0fabb56
Reproduces #1226 and denoland/deno#19021 ``` // Fails $ V8_FROM_SOURCE=1 cargo test exception // Passes $ V8_FROM_SOURCE=1 cargo test --release exception ``` We bisected this and this problem first appeared with V8 v11.2 upgrade. After further bisects we established that v8/v8@1f349da#diff-de75fc3e7b84373d94e18b4531827e8b749f9bbe05b59707e894e4e0ce2a1535 is the first V8 commit that causes this failure. However after more investigation we can't find any reason why that particular commit might cause this problem. It is only reproducible in debug build, but not release build. Current working theory is that it is a Rust compiler bug as changing the optimization level for this code makes the bug go away. This commit should be considered a band-aid that works around the problem, but doesn't fix it completely. We are gonna go with it as it unblocks un on day-to-day work, but ultimately we should track it down (or wait for another Rust upgrade which might fix it?). --------- Co-authored-by: Bert Belder <bertbelder@gmail.com> |
||
|---|---|---|
| .. | ||
| compile_fail | ||
| slots.rs | ||
| test_api.rs | ||
| test_api_entropy_source.rs | ||
| test_api_flags.rs | ||
| test_concurrent_isolate_creation_and_disposal.rs | ||
| test_platform_atomics_pump_message_loop.rs | ||
| test_single_threaded_default_platform.rs | ||
| test_ui.rs | ||