foster/forgejo - Foster's Laboratory

foster/forgejo

mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-25 13:19:37 -05:00

2 lines

80 B

Markdown

Raw Normal View History

feat: parse prefix from redis URI for queues (#3836) For security reasons, scoping access to a redis server via ACL rules is a good practice. Some parts of the codebase handles prefix like cache[^1] and session[^2], but the queue module doesn't. This patch adds this missing functionality to the queue module. Note about relevant test: I tried to keep the PR as small as possible (and reasonable), and not change how the test runs. Updated the existing test to use the same redis address and basically duplicated the test with the extra flag. It does NOT test if the keys are correct, it ensures only it works as expected. To make assertions about the keys, the whole test has to be updated as the general wrapper doesn't allow the main test to check anything provider (redis) specific property. That's not something I wanted to take on now. [^1]: https://codeberg.org/forgejo/forgejo/src/commit/e4c3c039bee28bc10f5e6fe3a3a98812d01ce4be/modules/cache/cache_redis.go#L139-L150 [^2]: https://codeberg.org/forgejo/forgejo/src/commit/e4c3c039bee28bc10f5e6fe3a3a98812d01ce4be/modules/session/redis.go#L122-L129 Signed-off-by: Victoria Nadasdi <victoria@efertone.me> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3836 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Co-authored-by: Victoria Nadasdi <victoria@efertone.me> Co-committed-by: Victoria Nadasdi <victoria@efertone.me>

2024-05-20 10:10:54 -04:00

Parse prefix parameter from redis URI for queues and use that as prefix to keys