foster/forgejo
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-11-23 08:47:42 -05:00
Code Issues Wiki Activity

Warn instead of reporting an error when a webhook cannot be found (#26039) (#26211)

Browse source 
Backport #26039 by @puni9869

Attemp fix: #25744
Fixing the log level when we delete any repo then we get error hook not
found by id. That should be warn level to reduce the noise in the logs.

Co-authored-by: puni9869 <80308335+puni9869@users.noreply.github.com>
(cherry picked from commit c5fe09db72)
This commit is contained in:
Giteabot 2023-07-29 22:47:46 +08:00 committed by Earl Warren
parent dfa114bfcb
commit 4c3dcdf815
No known key found for this signature in database
GPG key ID: 0579CB2928A78A00
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
services/webhook/webhook.go
View file

@ -5,6 +5,7 @@ package webhook
import ( import (
"context" "context"
"errors"
"fmt" "fmt"
"strings" "strings"
@ -111,7 +112,11 @@ func handler(items ...int64) []int64 {
for _, taskID := range items { for _, taskID := range items {
task, err := webhook_model.GetHookTaskByID(ctx, taskID) task, err := webhook_model.GetHookTaskByID(ctx, taskID)
if err != nil { if err != nil {
log.Error("GetHookTaskByID[%d] failed: %v", taskID, err) if errors.Is(err, util.ErrNotExist) {
log.Warn("GetHookTaskByID[%d] warn: %v", taskID, err)
} else {
log.Error("GetHookTaskByID[%d] failed: %v", taskID, err)
}
continue continue
} }