foster/forgejo
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-11-25 08:59:31 -05:00
Code Issues Wiki Activity

Use correct response code in push mirror creation response in v1_json.tmpl (#25476) (#25571)

Browse source 
Backport #25476 by @GeorgDangl

In the process of doing a bit of automation via the API, we've
discovered a _small_ issue in the Swagger definition. We tried to create
a push mirror for a repository, but our generated client raised an
exception due to an unexpected status code.

When looking at this function:

3c7f5ed7b5/routers/api/v1/repo/mirror.go (L236-L240)

We see it defines `201 - Created` as response:

3c7f5ed7b5/routers/api/v1/repo/mirror.go (L260-L262)

But it actually returns `200 - OK`:

3c7f5ed7b5/routers/api/v1/repo/mirror.go (L373)

So I've just updated the Swagger definitions to match the code😀

Co-authored-by: Georg Dangl <10274404+GeorgDangl@users.noreply.github.com>
This commit is contained in:
Giteabot 2023-06-28 19:00:56 -04:00 committed by GitHub
parent 77db40e084
commit b2b5c80cb2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
routers/api/v1/repo/mirror.go
View file

@ -258,7 +258,7 @@ func AddPushMirror(ctx *context.APIContext) {
// schema:
// "$ref": "#/definitions/CreatePushMirrorOption"
// responses:
// "201":
// "200":
// "$ref": "#/responses/PushMirror"
// "403":
// "$ref": "#/responses/forbidden"

2
templates/swagger/v1_json.tmpl generated
View file

@ -10729,7 +10729,7 @@
}
],
"responses": {
"201": {
"200": {
"$ref": "#/responses/PushMirror"
},
"400": {