foster/forgejo
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-22 12:54:53 -05:00
Code Issues Wiki Activity

[CLEANUP] make golangci-lint@v1.56.1 happy

Browse source
This commit is contained in:
Earl Warren 2024-02-15 16:19:36 +01:00
parent 79df409256
commit c8b177713a
No known key found for this signature in database
GPG key ID: 0579CB2928A78A00
8 changed files with 45 additions and 45 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
models/issues/issue_xref.go
View file

@ -46,10 +46,10 @@ func neuterCrossReferences(ctx context.Context, issueID, commentID int64) error
for i, c := range active { for i, c := range active {
ids[i] = c.ID ids[i] = c.ID
} }
return neuterCrossReferencesIds(ctx, nil, ids) return neuterCrossReferencesIDs(ctx, nil, ids)
} }
func neuterCrossReferencesIds(stdCtx context.Context, ctx *crossReferencesContext, ids []int64) error { func neuterCrossReferencesIDs(stdCtx context.Context, ctx *crossReferencesContext, ids []int64) error {
sess := db.GetEngine(stdCtx).In("id", ids).Cols("`ref_action`") sess := db.GetEngine(stdCtx).In("id", ids).Cols("`ref_action`")
if ctx != nil && ctx.OrigIssue.NoAutoTime { if ctx != nil && ctx.OrigIssue.NoAutoTime {
sess.SetExpr("updated_unix", ctx.OrigIssue.UpdatedUnix).NoAutoTime() sess.SetExpr("updated_unix", ctx.OrigIssue.UpdatedUnix).NoAutoTime()
@ -104,7 +104,7 @@ func (issue *Issue) createCrossReferences(stdCtx context.Context, ctx *crossRefe
} }
} }
if len(ids) > 0 { if len(ids) > 0 {
if err = neuterCrossReferencesIds(stdCtx, ctx, ids); err != nil { if err = neuterCrossReferencesIDs(stdCtx, ctx, ids); err != nil {
return err return err
} }
} }

12
models/issues/review_list.go
View file

@ -18,11 +18,11 @@ type ReviewList []*Review
// LoadReviewers loads reviewers // LoadReviewers loads reviewers
func (reviews ReviewList) LoadReviewers(ctx context.Context) error { func (reviews ReviewList) LoadReviewers(ctx context.Context) error {
reviewerIds := make([]int64, len(reviews)) reviewerIDs := make([]int64, len(reviews))
for i := 0; i < len(reviews); i++ { for i := 0; i < len(reviews); i++ {
reviewerIds[i] = reviews[i].ReviewerID reviewerIDs[i] = reviews[i].ReviewerID
} }
reviewers, err := user_model.GetPossibleUserByIDs(ctx, reviewerIds) reviewers, err := user_model.GetPossibleUserByIDs(ctx, reviewerIDs)
if err != nil { if err != nil {
return err return err
} }
@ -38,12 +38,12 @@ func (reviews ReviewList) LoadReviewers(ctx context.Context) error {
} }
func (reviews ReviewList) LoadIssues(ctx context.Context) error { func (reviews ReviewList) LoadIssues(ctx context.Context) error {
issueIds := container.Set[int64]{} issueIDs := container.Set[int64]{}
for i := 0; i < len(reviews); i++ { for i := 0; i < len(reviews); i++ {
issueIds.Add(reviews[i].IssueID) issueIDs.Add(reviews[i].IssueID)
} }
issues, err := GetIssuesByIDs(ctx, issueIds.Values()) issues, err := GetIssuesByIDs(ctx, issueIDs.Values())
if err != nil { if err != nil {
return err return err
} }

14
modules/git/log_name_status.go
View file

@ -143,19 +143,19 @@ func (g *LogNameStatusRepoParser) Next(treepath string, paths2ids map[string]int
} }
// Our "line" must look like: <commitid> SP (<parent> SP) * NUL // Our "line" must look like: <commitid> SP (<parent> SP) * NUL
commitIds := string(g.next) commitIDs := string(g.next)
if g.buffull { if g.buffull {
more, err := g.rd.ReadString('\x00') more, err := g.rd.ReadString('\x00')
if err != nil { if err != nil {
return nil, err return nil, err
} }
commitIds += more commitIDs += more
} }
commitIds = commitIds[:len(commitIds)-1] commitIDs = commitIDs[:len(commitIDs)-1]
splitIds := strings.Split(commitIds, " ") splitIDs := strings.Split(commitIDs, " ")
ret.CommitID = splitIds[0] ret.CommitID = splitIDs[0]
if len(splitIds) > 1 { if len(splitIDs) > 1 {
ret.ParentIDs = splitIds[1:] ret.ParentIDs = splitIDs[1:]
} }
// now read the next "line" // now read the next "line"

2
modules/repository/generate.go
View file

@ -94,7 +94,7 @@ type GiteaTemplate struct {
} }
// Globs parses the .gitea/template globs or returns them if they were already parsed // Globs parses the .gitea/template globs or returns them if they were already parsed
func (gt GiteaTemplate) Globs() []glob.Glob { func (gt *GiteaTemplate) Globs() []glob.Glob {
if gt.globs != nil { if gt.globs != nil {
return gt.globs return gt.globs
} }

8
routers/web/org/projects.go
View file

@ -377,16 +377,16 @@ func ViewProject(ctx *context.Context) {
linkedPrsMap := make(map[int64][]*issues_model.Issue) linkedPrsMap := make(map[int64][]*issues_model.Issue)
for _, issuesList := range issuesMap { for _, issuesList := range issuesMap {
for _, issue := range issuesList { for _, issue := range issuesList {
var referencedIds []int64 var referencedIDs []int64
for _, comment := range issue.Comments { for _, comment := range issue.Comments {
if comment.RefIssueID != 0 && comment.RefIsPull { if comment.RefIssueID != 0 && comment.RefIsPull {
referencedIds = append(referencedIds, comment.RefIssueID) referencedIDs = append(referencedIDs, comment.RefIssueID)
} }
} }
if len(referencedIds) > 0 { if len(referencedIDs) > 0 {
if linkedPrs, err := issues_model.Issues(ctx, &issues_model.IssuesOptions{ if linkedPrs, err := issues_model.Issues(ctx, &issues_model.IssuesOptions{
IssueIDs: referencedIds, IssueIDs: referencedIDs,
IsPull: util.OptionalBoolTrue, IsPull: util.OptionalBoolTrue,
}); err == nil { }); err == nil {
linkedPrsMap[issue.ID] = linkedPrs linkedPrsMap[issue.ID] = linkedPrs

8
routers/web/repo/projects.go
View file

@ -339,16 +339,16 @@ func ViewProject(ctx *context.Context) {
linkedPrsMap := make(map[int64][]*issues_model.Issue) linkedPrsMap := make(map[int64][]*issues_model.Issue)
for _, issuesList := range issuesMap { for _, issuesList := range issuesMap {
for _, issue := range issuesList { for _, issue := range issuesList {
var referencedIds []int64 var referencedIDs []int64
for _, comment := range issue.Comments { for _, comment := range issue.Comments {
if comment.RefIssueID != 0 && comment.RefIsPull { if comment.RefIssueID != 0 && comment.RefIsPull {
referencedIds = append(referencedIds, comment.RefIssueID) referencedIDs = append(referencedIDs, comment.RefIssueID)
} }
} }
if len(referencedIds) > 0 { if len(referencedIDs) > 0 {
if linkedPrs, err := issues_model.Issues(ctx, &issues_model.IssuesOptions{ if linkedPrs, err := issues_model.Issues(ctx, &issues_model.IssuesOptions{
IssueIDs: referencedIds, IssueIDs: referencedIDs,
IsPull: util.OptionalBoolTrue, IsPull: util.OptionalBoolTrue,
}); err == nil { }); err == nil {
linkedPrsMap[issue.ID] = linkedPrs linkedPrsMap[issue.ID] = linkedPrs

8
routers/web/user/home.go
View file

@ -296,17 +296,17 @@ func Milestones(ctx *context.Context) {
} }
} }
showRepoIds := make(container.Set[int64], len(showRepos)) showRepoIDs := make(container.Set[int64], len(showRepos))
for _, repo := range showRepos { for _, repo := range showRepos {
if repo.ID > 0 { if repo.ID > 0 {
showRepoIds.Add(repo.ID) showRepoIDs.Add(repo.ID)
} }
} }
if len(repoIDs) == 0 { if len(repoIDs) == 0 {
repoIDs = showRepoIds.Values() repoIDs = showRepoIDs.Values()
} }
repoIDs = slices.DeleteFunc(repoIDs, func(v int64) bool { repoIDs = slices.DeleteFunc(repoIDs, func(v int64) bool {
return !showRepoIds.Contains(v) return !showRepoIDs.Contains(v)
}) })
var pagerCount int var pagerCount int

32
services/repository/create_test.go
View file

@ -52,12 +52,12 @@ func TestIncludesAllRepositoriesTeams(t *testing.T) {
assert.True(t, ownerTeam.IncludesAllRepositories, "Owner team includes all repositories") assert.True(t, ownerTeam.IncludesAllRepositories, "Owner team includes all repositories")
// Create repos. // Create repos.
repoIds := make([]int64, 0) repoIDs := make([]int64, 0)
for i := 0; i < 3; i++ { for i := 0; i < 3; i++ {
r, err := CreateRepositoryDirectly(db.DefaultContext, user, org.AsUser(), CreateRepoOptions{Name: fmt.Sprintf("repo-%d", i)}) r, err := CreateRepositoryDirectly(db.DefaultContext, user, org.AsUser(), CreateRepoOptions{Name: fmt.Sprintf("repo-%d", i)})
assert.NoError(t, err, "CreateRepository %d", i) assert.NoError(t, err, "CreateRepository %d", i)
if r != nil { if r != nil {
repoIds = append(repoIds, r.ID) repoIDs = append(repoIDs, r.ID)
} }
} }
// Get fresh copy of Owner team after creating repos. // Get fresh copy of Owner team after creating repos.
@ -93,10 +93,10 @@ func TestIncludesAllRepositoriesTeams(t *testing.T) {
}, },
} }
teamRepos := [][]int64{ teamRepos := [][]int64{
repoIds, repoIDs,
repoIds, repoIDs,
{}, {},
repoIds, repoIDs,
{}, {},
} }
for i, team := range teams { for i, team := range teams {
@ -109,7 +109,7 @@ func TestIncludesAllRepositoriesTeams(t *testing.T) {
// Update teams and check repositories. // Update teams and check repositories.
teams[3].IncludesAllRepositories = false teams[3].IncludesAllRepositories = false
teams[4].IncludesAllRepositories = true teams[4].IncludesAllRepositories = true
teamRepos[4] = repoIds teamRepos[4] = repoIDs
for i, team := range teams { for i, team := range teams {
assert.NoError(t, models.UpdateTeam(db.DefaultContext, team, false, true), "%s: UpdateTeam", team.Name) assert.NoError(t, models.UpdateTeam(db.DefaultContext, team, false, true), "%s: UpdateTeam", team.Name)
testTeamRepositories(team.ID, teamRepos[i]) testTeamRepositories(team.ID, teamRepos[i])
@ -119,27 +119,27 @@ func TestIncludesAllRepositoriesTeams(t *testing.T) {
r, err := CreateRepositoryDirectly(db.DefaultContext, user, org.AsUser(), CreateRepoOptions{Name: "repo-last"}) r, err := CreateRepositoryDirectly(db.DefaultContext, user, org.AsUser(), CreateRepoOptions{Name: "repo-last"})
assert.NoError(t, err, "CreateRepository last") assert.NoError(t, err, "CreateRepository last")
if r != nil { if r != nil {
repoIds = append(repoIds, r.ID) repoIDs = append(repoIDs, r.ID)
} }
teamRepos[0] = repoIds teamRepos[0] = repoIDs
teamRepos[1] = repoIds teamRepos[1] = repoIDs
teamRepos[4] = repoIds teamRepos[4] = repoIDs
for i, team := range teams { for i, team := range teams {
testTeamRepositories(team.ID, teamRepos[i]) testTeamRepositories(team.ID, teamRepos[i])
} }
// Remove repo and check teams repositories. // Remove repo and check teams repositories.
assert.NoError(t, DeleteRepositoryDirectly(db.DefaultContext, user, repoIds[0]), "DeleteRepository") assert.NoError(t, DeleteRepositoryDirectly(db.DefaultContext, user, repoIDs[0]), "DeleteRepository")
teamRepos[0] = repoIds[1:] teamRepos[0] = repoIDs[1:]
teamRepos[1] = repoIds[1:] teamRepos[1] = repoIDs[1:]
teamRepos[3] = repoIds[1:3] teamRepos[3] = repoIDs[1:3]
teamRepos[4] = repoIds[1:] teamRepos[4] = repoIDs[1:]
for i, team := range teams { for i, team := range teams {
testTeamRepositories(team.ID, teamRepos[i]) testTeamRepositories(team.ID, teamRepos[i])
} }
// Wipe created items. // Wipe created items.
for i, rid := range repoIds { for i, rid := range repoIDs {
if i > 0 { // first repo already deleted. if i > 0 { // first repo already deleted.
assert.NoError(t, DeleteRepositoryDirectly(db.DefaultContext, user, rid), "DeleteRepository %d", i) assert.NoError(t, DeleteRepositoryDirectly(db.DefaultContext, user, rid), "DeleteRepository %d", i)
} }