CaiCandong
7ad31567cd
Fix ldap admin privileges update bug ( #27051 )
...
When the user does not set a username lookup condition, LDAP will get an
empty string `""` for the user, hence the following code
```
if isExist, err := user_model.IsUserExist(db.DefaultContext, 0, sr.Username)
```
The user presence determination will always be nonexistent, so updates
to user information will never be performed.
Fix #27049
2023-10-01 11:32:12 +00:00
Lunny Xiao
6e87a44034
Allow get release download files and lfs files with oauth2 token format ( #26430 )
...
Fix #26165
Fix #25257
2023-10-01 10:41:52 +00:00
CaiCandong
6b65c41ebf
Fix missing ctx for GetRepoLink in dashboard ( #27372 )
...
As title
Fix #27369
Regression of #27265
2023-10-01 09:26:28 +00:00
Denys Konovalov
4ab597f479
highlight user details link ( #26998 )
...
This PR adds a separated column in the users table for operations. The
username link now redirects back to user page.
Resolves
https://github.com/go-gitea/gitea/pull/26713#pullrequestreview-1603001285
Co-authored-by: silverwind <me@silverwind.io>
2023-10-01 11:58:24 +08:00
silverwind
83f571628d
Feed UI Improvements ( #27356 )
...
Various improvements related to feeds:
- Fix markdown rendering
- Increase font size from 13px to default 14px via `flex-item`
- Add style to hashes
- Move the timestamp to title line. I realize it's not optimal for
translation, we may need to change all these translations
Before:
<img width="768" alt="Screenshot 2023-09-29 at 22 52 58"
src="https://github.com/go-gitea/gitea/assets/115237/edda8b84-23cf-4a43-90ad-a892798f4e6c ">
After:
<img width="781" alt="Screenshot 2023-09-29 at 22 58 09"
src="https://github.com/go-gitea/gitea/assets/115237/7097474d-efcf-4f22-a2ab-834a4e25c4e8 ">
2023-09-30 15:48:34 +00:00
Rafael Heard
4cb51cb985
Absolute positioned checkboxes overlay floated elements ( #26870 )
...
Currently, checkboxes are positioned as absolute. This positioning
causes the input to overlay an element that has been floated within the
editor. Floated elements are useful if you want your text to wrap around
this element. This PR fixes the overlaying of checkboxes by removing the
absolute positioning, updating the `ul` padding, and
displaying`.task-list-item` `flex` to ensure inputs and the associated
label are on the same line.
Screenshots:
Before:
<img width="762" alt="Screenshot 2023-09-01 at 3 40 59 PM"
src="https://github.com/go-gitea/gitea/assets/6152817/570247c7-7f5c-4697-bfc9-ad4655e37991 ">
After:
<img width="762" alt="Screenshot 2023-09-01 at 3 42 20 PM"
src="https://github.com/go-gitea/gitea/assets/6152817/db53df45-1294-4eee-84c0-b21ac4fdf805 ">
---------
Co-authored-by: rafh <rafaelheard@gmail.com>
2023-09-30 09:30:44 +00:00
Lunny Xiao
7d14aa062f
Fix template bug ( #27362 )
...
Fix #27361
2023-09-30 17:03:04 +08:00
GiteaBot
4f169e4b47
[skip ci] Updated translations via Crowdin
2023-09-30 00:22:01 +00:00
yp05327
393193a3e0
Fix repo count in org action settings ( #27245 )
...
Only in org action settings, repo count is missing
Before:
In other setting page:
After:
2023-09-29 15:46:07 +00:00
Panagiotis "Ivory" Vasilopoulos
65e09a303e
Introduce fixes and more rigorous tests for 'Show on a map' feature ( #26803 )
...
This change introduces a fix for the PR #26214 to set the UserLocationMapURL correctly.
2023-09-29 14:57:06 +00:00
Lunny Xiao
c3b7231966
Add protected branch name description ( #27257 )
...
Co-authored-by: delvh <dev.lh@web.de>
2023-09-29 14:02:35 +00:00
6543
2a2b0cb1d2
rename TotalTimes() to TotalTimesForEachUser() ( #27261 )
...
make function name more descriptive as it would otherwise imply it could
be used for e.g. #26672 too ...
---
*Sponsored by Kithara Software GmbH*
2023-09-29 13:04:14 +00:00
JakobDev
cf0df023be
More db.DefaultContext refactor ( #27265 )
...
Part of #27065
This PR touches functions used in templates. As templates are not static
typed, errors are harder to find, but I hope I catch it all. I think
some tests from other persons do not hurt.
2023-09-29 12:12:54 +00:00
yp05327
3945c26722
Improve tree not found page ( #26570 )
...
Before:
After:
In Github:
https://github.com/yp05327/test/blob/main/test.drawio
Updated:
UI changed
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-09-29 07:42:39 +00:00
Marcin Kuźmiński
89fa8f9896
Update comparison page with RhodeCode CE & EE ( #27329 )
...
Update RhodeCode features and add EE version
2023-09-29 13:31:54 +08:00
Lunny Xiao
968be05bcc
Add logs for data broken of comment review ( #27326 )
...
Fix #27306
2023-09-29 02:31:36 +00:00
Dmitry Sharshakov
5e02e3b7ee
Add support for forking single branch ( #25821 )
...
Fixes #25117
Add UI for choosing branch to fork
Change default branch on single-branch forks
---------
Co-authored-by: Denys Konovalov <kontakt@denyskon.de>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2023-09-29 09:48:39 +08:00
GiteaBot
e8840e7e2b
[skip ci] Updated translations via Crowdin
2023-09-29 00:23:01 +00:00
Nanguan Lin
15a504cb9f
Fix the approval count of PR when there is no protection branch rule ( #27272 )
...
As title
2023-09-28 23:24:36 +00:00
JakobDev
9d9cebc5e7
Add Index to comment.dependent_issue_id ( #27325 )
...
This Column is missing index. It is used by
[issue_service.deleteIssue](7ea2a910ce/services/issue/issue.go (L300)
2023-09-28 22:58:35 +02:00
Zettat123
3fcad582c9
Improvements of releases list and tags list ( #25859 )
...
Follow #23465 and #25624
This PR introduces the following improvements:
- We do not need to call `GetTags` to get tags because tags have been
loaded by `RepoAssignment`
ef90fdbd1d/modules/context/repo.go (L663-L668)ef90fdbd1d/modules/context/repo.go (L538-L551)
2023-09-28 13:21:47 +00:00
JakobDev
1c039b4e1e
Fix Bug in Issue Config when only contact links are set ( #26521 )
...
Blank Issues should be enabled if they are not explicit disabled through
the `blank_issues_enabled` field of the Issue Config. The Implementation
has currently a Bug: If you create a Issue Config file with only
`contact_links` and without a `blank_issues_enabled` field,
`blank_issues_enabled` is set to false by default.
The fix is only one line, but I decided to also improve the tests to
make sure there are no other problems with the Implementation.
This is a bugfix, so it should be backported to 1.20.
2023-09-28 20:16:40 +08:00
wxiaoguang
1f00bc44b2
Fix review UI ( #27322 )
...
Close #26730
1. The `diff-detail-box` was abused, it shouldn't be used for
"DiffFileList/DiffFileTree".
2. Fix the sticky position for various screens.
2023-09-28 10:00:26 +00:00
wxiaoguang
72c68177ab
Improve issue history dialog and make poster can delete their own history ( #27323 )
...
Fix #27313 (see the comment)
And some UI improvements:
### Before
### After
2023-09-28 08:43:20 +00:00
wxiaoguang
7ea2a910ce
Improve branch list UI ( #27319 )
...
1. Put the `"octicon-shield-lock"` into the flex container, then it
doesn't need a separate flex box
2. Remove some unnecessary `gt-df` helpers
3. Make `btn` button has the same flex behavior as `ui button`
2023-09-28 04:04:32 +00:00
6543
15fa0383fb
doctor: delete action entries without existing user ( #27292 )
...
just extend doctor with a usefully check :)
Co-authored-by: techknowlogick <techknowlogick@gitea.com>
2023-09-28 03:03:08 +00:00
Earl Warren
98f02203f9
fix orphan check for deleted branch ( #27310 )
...
- Modify the deleted branch orphan check to check for the new table
instead.
- Regression from 6e19484f4dhttps://codeberg.org/forgejo/forgejo/issues/1522
(cherry picked from commit c1d888686f
2023-09-28 02:07:33 +00:00
Lunny Xiao
673cf6af76
make writing main test easier ( #27270 )
...
This PR removed `unittest.MainTest` the second parameter
`TestOptions.GiteaRoot`. Now it detects the root directory by current
working directory.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2023-09-28 01:38:53 +00:00
GiteaBot
e74a3b18af
[skip ci] Updated translations via Crowdin
2023-09-28 00:22:57 +00:00
yp05327
e5e1d842c0
Fix protected branch icon location ( #26576 )
2023-09-27 22:21:31 +00:00
Nanguan Lin
70f8d10fc5
move the gitea admin subcommands into separate files ( #27307 )
...
As title.
Probably it's better to put those sub cmd to different dirs. Will do
that in the future.
2023-09-27 12:25:38 +00:00
Lunny Xiao
5600504eed
Fix chinese translation ( #27296 )
...
Fix translation from #27291
Source Map will be kept as English in Chinese usage habit.
2023-09-27 08:15:12 +00:00
techknowlogick
9e446dbf04
bump bleve ( #27300 )
...
Co-authored-by: yp05327 <576951401@qq.com>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-09-27 07:10:58 +00:00
Lunny Xiao
3b2da7e4ae
Redefine the meaning of column is_active to make Actions Registration Token generation easier ( #27143 )
...
Partially Fix #25041
This PR redefined the meaning of column `is_active` in table
`action_runner_token`.
Before this PR, `is_active` means whether it has been used by any
runner. If it's true, other runner cannot use it to register again.
In this PR, `is_active` means whether it's validated to be used to
register runner. And if it's true, then it can be used to register
runners until it become false. When creating a new `is_active` register
token, any previous tokens will be set `is_active` to false.
2023-09-27 05:37:48 +00:00
silverwind
ee27b94b2c
Use vitest globals ( #27102 )
...
Enable [globals](https://vitest.dev/config/#globals ) in vitest, reducing
the noise in test files.
2023-09-27 04:37:13 +00:00
yp05327
5ef5a0ade6
Fix divider in subscription page ( #27298 )
...
the divider should always display in the subscription page.
Co-authored-by: techknowlogick <techknowlogick@gitea.com>
2023-09-27 04:00:57 +00:00
Lunny Xiao
e59c9e3ecd
Fix yaml test ( #27297 )
2023-09-26 23:30:03 -04:00
silverwind
c5247eff73
Enable production source maps for index.js, fix CSS sourcemaps ( #27291 )
...
Previously, the production build never output sourcemaps. Now we emit
one file for `index.js` because it is the most likely one where we need
to be able to better debug reported issues like
https://github.com/go-gitea/gitea/issues/27213 . This will currently
increase the binary size of gitea by around 700kB which is what the
gzipped source map file has.
Also, I fixed the CSS sourcemap generation which was broken since the
introduction of lightningcss.
2023-09-26 22:05:49 -04:00
wxiaoguang
6967c13ad2
Fix some animation bugs ( #27287 )
...
Fix #27286
Replace #27279
2023-09-27 01:15:58 +00:00
silverwind
709c2fad8a
Add missed return to actions view fetch ( #27289 )
...
Should fix: #27213
2023-09-27 08:34:52 +08:00
Lunny Xiao
eab20cb6bd
Fix more yaml lint errors ( #27284 )
...
Fix #27268
2023-09-26 12:56:42 -04:00
delvh
1f89a45926
Fix incorrect change from #27231 ( #27275 )
2023-09-26 13:10:29 +00:00
wxiaoguang
939d410a93
Add missing IconHTML size ( #27269 )
...
Fix #27223
Regression of #27122
2023-09-26 19:59:04 +08:00
wxiaoguang
d0012c8806
Document the queue item's marshaling behavior ( #27271 )
...
Close #26843
2023-09-26 13:58:57 +08:00
GiteaBot
3f82ca38af
[skip ci] Updated translations via Crowdin
2023-09-26 00:23:08 +00:00
JakobDev
7047df36d4
Another round of db.DefaultContext refactor ( #27103 )
...
Part of #27065
---------
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
2023-09-25 13:17:37 +00:00
wxiaoguang
93bd4351bf
Fix more "locale" usages ( #27259 )
2023-09-25 20:42:40 +08:00
delvh
7960ba7e2b
Always use ctx.Locale.Tr inside templates ( #27231 )
2023-09-25 08:56:50 +00:00
Yarden Shoham
e6d8b14620
Disable Test Delivery and Replay webhook buttons when webhook is inactive ( #27211 )
...
These buttons are now disabled when the webhook is not active.
The buttons were always enabled before this change.
- Fixes #26824
- Replaces #26814
# Before
# After
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
2023-09-25 07:33:00 +00:00
yp05327
65d0b7c13a
Add missing public user visibility in user details page ( #27246 )
...
It seems that `Public` user visibility is missing in the template.
Before:
After:
2023-09-25 08:27:03 +02:00
