forgejo

foster/forgejo

Fork 0

mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-23 12:59:11 -05:00

Commit graph

Author SHA1 Message Date

Author	SHA1	Message	Date
wxiaoguang	ac8d71ff07	Refactor branch/tag selector to Vue SFC (#23421 ) Follow #23394 There were many bad smells in old code. This PR only moves the code into Vue SFC, doesn't touch the unrelated logic. update: after `5f23218c85` , there should be no usage of the vue-rumtime-compiler anymore (hopefully), so I think this PR could close #19851 --------- Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2023-03-14 17:51:20 +08:00
wxiaoguang	a7e98d70b6	Fix the show/hide methods for string selector (#23042 ) At that moment I made a mistake (failed to detect a JS variable type correctly) Close #23040	2023-02-21 11:09:03 -06:00
wxiaoguang	d32af84a10	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950 ) Close #22847 This PR: * introduce Gitea's own `showElem` and related functions * remove jQuery show/hide * remove .hide class * remove inline style=display:none From now on: do not use: * "[hidden]" attribute: it's too weak, can not be applied to an element with "display: flex" * ".hidden" class: it has been polluted by Fomantic UI in many cases * inline style="display: none": it's difficult to tweak * jQuery's show/hide/toggle: it can not show/hide elements with "display: xxx !important" only use: * this ".gt-hidden" class * showElem/hideElem/toggleElem functions in "utils/dom.js" cc: @silverwind , this is the all-in-one PR	2023-02-19 12:06:14 +08:00

wxiaoguang

ac8d71ff07

Refactor branch/tag selector to Vue SFC (#23421 )

Follow #23394

There were many bad smells in old code. This PR only moves the code into
Vue SFC, doesn't touch the unrelated logic.

update: after
5f23218c85
, there should be no usage of the vue-rumtime-compiler anymore
(hopefully), so I think this PR could close #19851

---------

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>

2023-03-14 17:51:20 +08:00

wxiaoguang

a7e98d70b6

Fix the show/hide methods for string selector (#23042 )

At that moment I made a mistake (failed to detect a JS variable type
correctly)

Close #23040

2023-02-21 11:09:03 -06:00

wxiaoguang

d32af84a10

Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950 )

Close #22847

This PR:

* introduce Gitea's own `showElem` and related functions
* remove jQuery show/hide
* remove .hide class
* remove inline style=display:none 

From now on:

do not use:
* "[hidden]" attribute: it's too weak, can not be applied to an element
with "display: flex"
* ".hidden" class: it has been polluted by Fomantic UI in many cases
* inline style="display: none": it's difficult to tweak
* jQuery's show/hide/toggle: it can not show/hide elements with
"display: xxx !important"

only use:
* this ".gt-hidden" class
* showElem/hideElem/toggleElem functions in "utils/dom.js"

cc: @silverwind , this is the all-in-one PR

2023-02-19 12:06:14 +08:00

3 commits