mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-22 12:54:53 -05:00
2072ff75e8
Fixes: https://github.com/go-gitea/gitea/issues/30384
On repo settings page, there id `repo_name` was used 5 times on the same
page, some in modal and such. I think we are better off just
auto-generating these IDs in the future so that labels link up with
their form element.
Ideally this id generation would be done in backend in a subtemplate,
but seeing that we already have similar JS patches for checkboxes, I
took the easy path for now.
I also checked that these `#repo_name` were not in use in JS and the
only case where this id appears in JS is on the migration page where
it's still there.
---------
Co-authored-by: Giteabot <teabot@gitea.io>
(cherry picked from commit d4ec6b3d16496ce3b479d5a08f79823122dc2b7b)
Conflicts:
- templates/repo/settings/options.tmpl
Conflict resolved by manually removing all `id` and `for`
attributes from elements that had `repo_name` as their id.
(cherry picked from commit a01387f5b1)
34 lines
1.5 KiB
JavaScript
34 lines
1.5 KiB
JavaScript
import $ from 'jquery';
|
|
import {initFomanticApiPatch} from './fomantic/api.js';
|
|
import {initAriaCheckboxPatch} from './fomantic/checkbox.js';
|
|
import {initAriaFormFieldPatch} from './fomantic/form.js';
|
|
import {initAriaDropdownPatch} from './fomantic/dropdown.js';
|
|
import {initAriaModalPatch} from './fomantic/modal.js';
|
|
import {initFomanticTransition} from './fomantic/transition.js';
|
|
import {svg} from '../svg.js';
|
|
|
|
export const fomanticMobileScreen = window.matchMedia('only screen and (max-width: 767.98px)');
|
|
|
|
export function initGiteaFomantic() {
|
|
// Silence fomantic's error logging when tabs are used without a target content element
|
|
$.fn.tab.settings.silent = true;
|
|
|
|
// By default, use "exact match" for full text search
|
|
$.fn.dropdown.settings.fullTextSearch = 'exact';
|
|
// Do not use "cursor: pointer" for dropdown labels
|
|
$.fn.dropdown.settings.className.label += ' tw-cursor-default';
|
|
// Always use Gitea's SVG icons
|
|
$.fn.dropdown.settings.templates.label = function(_value, text, preserveHTML, className) {
|
|
const escape = $.fn.dropdown.settings.templates.escape;
|
|
return escape(text, preserveHTML) + svg('octicon-x', 16, `${className.delete} icon`);
|
|
};
|
|
|
|
initFomanticTransition();
|
|
initFomanticApiPatch();
|
|
|
|
// Use the patches to improve accessibility, these patches are designed to be as independent as possible, make it easy to modify or remove in the future.
|
|
initAriaCheckboxPatch();
|
|
initAriaFormFieldPatch();
|
|
initAriaDropdownPatch();
|
|
initAriaModalPatch();
|
|
}
|