mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-22 12:54:53 -05:00
63736e8301
- For WebAuthn Credential level 3, the `backup_eligible` and `backup_state` flags are checked if they are consistent with the values given on login. Forgejo never stored this data, so add a database migration that makes all webauthn credentials 'legacy' and on the next first use capture the values of `backup_eligible` and `backup_state`. As suggested in https://github.com/go-webauthn/webauthn/discussions/219#discussioncomment-10429662 - Adds unit tests. - Add E2E test.
78 lines
3 KiB
Go
78 lines
3 KiB
Go
// Copyright 2020 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package auth_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
auth_model "code.gitea.io/gitea/models/auth"
|
|
"code.gitea.io/gitea/models/db"
|
|
"code.gitea.io/gitea/models/unittest"
|
|
|
|
"github.com/go-webauthn/webauthn/webauthn"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestGetWebAuthnCredentialByID(t *testing.T) {
|
|
require.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
res, err := auth_model.GetWebAuthnCredentialByID(db.DefaultContext, 1)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, "WebAuthn credential", res.Name)
|
|
|
|
_, err = auth_model.GetWebAuthnCredentialByID(db.DefaultContext, 342432)
|
|
require.Error(t, err)
|
|
assert.True(t, auth_model.IsErrWebAuthnCredentialNotExist(err))
|
|
}
|
|
|
|
func TestGetWebAuthnCredentialsByUID(t *testing.T) {
|
|
require.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
res, err := auth_model.GetWebAuthnCredentialsByUID(db.DefaultContext, 32)
|
|
require.NoError(t, err)
|
|
assert.Len(t, res, 1)
|
|
assert.Equal(t, "WebAuthn credential", res[0].Name)
|
|
}
|
|
|
|
func TestWebAuthnCredential_TableName(t *testing.T) {
|
|
assert.Equal(t, "webauthn_credential", auth_model.WebAuthnCredential{}.TableName())
|
|
}
|
|
|
|
func TestWebAuthnCredential_UpdateSignCount(t *testing.T) {
|
|
require.NoError(t, unittest.PrepareTestDatabase())
|
|
cred := unittest.AssertExistsAndLoadBean(t, &auth_model.WebAuthnCredential{ID: 1})
|
|
cred.SignCount = 1
|
|
require.NoError(t, cred.UpdateSignCount(db.DefaultContext))
|
|
unittest.AssertExistsIf(t, true, &auth_model.WebAuthnCredential{ID: 1, SignCount: 1})
|
|
}
|
|
|
|
func TestWebAuthnCredential_UpdateLargeCounter(t *testing.T) {
|
|
require.NoError(t, unittest.PrepareTestDatabase())
|
|
cred := unittest.AssertExistsAndLoadBean(t, &auth_model.WebAuthnCredential{ID: 1})
|
|
cred.SignCount = 0xffffffff
|
|
require.NoError(t, cred.UpdateSignCount(db.DefaultContext))
|
|
unittest.AssertExistsIf(t, true, &auth_model.WebAuthnCredential{ID: 1, SignCount: 0xffffffff})
|
|
}
|
|
|
|
func TestWebAuthenCredential_UpdateFromLegacy(t *testing.T) {
|
|
require.NoError(t, unittest.PrepareTestDatabase())
|
|
cred := unittest.AssertExistsAndLoadBean(t, &auth_model.WebAuthnCredential{ID: 1, Legacy: true})
|
|
cred.Legacy = false
|
|
cred.BackupEligible = true
|
|
cred.BackupState = true
|
|
require.NoError(t, cred.UpdateFromLegacy(db.DefaultContext))
|
|
unittest.AssertExistsIf(t, true, &auth_model.WebAuthnCredential{ID: 1, BackupEligible: true, BackupState: true}, "legacy = false")
|
|
}
|
|
|
|
func TestCreateCredential(t *testing.T) {
|
|
require.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
res, err := auth_model.CreateCredential(db.DefaultContext, 1, "WebAuthn Created Credential", &webauthn.Credential{ID: []byte("Test"), Flags: webauthn.CredentialFlags{BackupEligible: true, BackupState: true}})
|
|
require.NoError(t, err)
|
|
assert.Equal(t, "WebAuthn Created Credential", res.Name)
|
|
assert.Equal(t, []byte("Test"), res.CredentialID)
|
|
|
|
unittest.AssertExistsIf(t, true, &auth_model.WebAuthnCredential{Name: "WebAuthn Created Credential", UserID: 1, BackupEligible: true, BackupState: true}, "legacy = false")
|
|
}
|