1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-02 10:07:07 -05:00
forgejo/routers/web
M Hickford 191a74d622
Record OAuth client type at registration (#21316)
The OAuth spec [defines two types of
client](https://datatracker.ietf.org/doc/html/rfc6749#section-2.1),
confidential and public. Previously Gitea assumed all clients to be
confidential.

> OAuth defines two client types, based on their ability to authenticate
securely with the authorization server (i.e., ability to
>   maintain the confidentiality of their client credentials):
>
>   confidential
> Clients capable of maintaining the confidentiality of their
credentials (e.g., client implemented on a secure server with
> restricted access to the client credentials), or capable of secure
client authentication using other means.
>
>   **public
> Clients incapable of maintaining the confidentiality of their
credentials (e.g., clients executing on the device used by the resource
owner, such as an installed native application or a web browser-based
application), and incapable of secure client authentication via any
other means.**
>
> The client type designation is based on the authorization server's
definition of secure authentication and its acceptable exposure levels
of client credentials. The authorization server SHOULD NOT make
assumptions about the client type.

 https://datatracker.ietf.org/doc/html/rfc8252#section-8.4

> Authorization servers MUST record the client type in the client
registration details in order to identify and process requests
accordingly.

Require PKCE for public clients:
https://datatracker.ietf.org/doc/html/rfc8252#section-8.1

> Authorization servers SHOULD reject authorization requests from native
apps that don't use PKCE by returning an error message

Fixes #21299

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2022-10-24 15:59:24 +08:00
..
admin Add system setting table with cache and also add cache supports for user setting (#18058) 2022-10-17 07:29:26 +08:00
auth Record OAuth client type at registration (#21316) 2022-10-24 15:59:24 +08:00
dev Make better use of i18n (#20096) 2022-06-26 22:19:22 +08:00
events Improve Stopwatch behavior (#18930) 2022-04-25 22:45:22 +02:00
explore Remove deleted repos from searchresult (#21512) 2022-10-22 17:23:20 +08:00
feed Show private data in feeds (#21369) 2022-10-07 22:06:04 +01:00
healthcheck Update go-chi/cache to utilize Ping() (#19719) 2022-05-15 20:43:27 +02:00
misc Fix panic in team repos API (#19431) 2022-04-20 18:43:26 +08:00
org move invite by mail to services package (#21513) 2022-10-20 11:23:31 +08:00
repo adapt README_{Country}.md stype name in localizedExtensions (#21486) 2022-10-24 14:12:15 +08:00
user Record OAuth client type at registration (#21316) 2022-10-24 15:59:24 +08:00
auth.go Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
auth_windows.go Let web and API routes have different auth methods group (#19168) 2022-03-28 12:46:28 +08:00
base.go Share HTML template renderers and create a watcher framework (#20218) 2022-08-28 10:43:25 +01:00
goget.go Refactor legacy unknwon/com package, improve golangci lint (#19284) 2022-04-01 16:47:50 +08:00
home.go Add sitemap support (#18407) 2022-06-25 19:06:01 +02:00
metrics.go Update HTTP status codes to modern codes (#18063) 2022-03-23 12:54:07 +08:00
nodeinfo.go Add nodeinfo endpoint for federation purposes (#16953) 2021-09-28 01:38:06 +02:00
swagger_json.go Refactor routers directory (#15800) 2021-06-09 01:33:54 +02:00
web.go Added check for disabled Packages (#21540) 2022-10-22 11:24:09 +08:00
webfinger.go Fix various typos (#20338) 2022-07-12 23:32:37 +02:00