mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-22 12:54:53 -05:00
0cb46f63df
If `[email.incoming].USE_TLS` is set, but the port isn't, infer the default from `.USE_TLS`: set the port to 993 if using tls, and to 143 otherwise. Explicitly setting a port overrides this. Fixes #3357. Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
74 lines
1.7 KiB
Go
74 lines
1.7 KiB
Go
// Copyright 2024 The Forgejo Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package setting
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func Test_loadIncomingEmailFrom(t *testing.T) {
|
|
makeBaseConfig := func() (ConfigProvider, ConfigSection) {
|
|
cfg, _ := NewConfigProviderFromData("")
|
|
sec := cfg.Section("email.incoming")
|
|
sec.NewKey("ENABLED", "true")
|
|
sec.NewKey("REPLY_TO_ADDRESS", "forge+%{token}@example.com")
|
|
|
|
return cfg, sec
|
|
}
|
|
resetIncomingEmailPort := func() func() {
|
|
return func() {
|
|
IncomingEmail.Port = 0
|
|
}
|
|
}
|
|
|
|
t.Run("aliases", func(t *testing.T) {
|
|
cfg, sec := makeBaseConfig()
|
|
sec.NewKey("USER", "jane.doe@example.com")
|
|
sec.NewKey("PASSWD", "y0u'll n3v3r gUess th1S!!1")
|
|
|
|
loadIncomingEmailFrom(cfg)
|
|
|
|
assert.EqualValues(t, "jane.doe@example.com", IncomingEmail.Username)
|
|
assert.EqualValues(t, "y0u'll n3v3r gUess th1S!!1", IncomingEmail.Password)
|
|
})
|
|
|
|
t.Run("Port settings", func(t *testing.T) {
|
|
t.Run("no port, no tls", func(t *testing.T) {
|
|
defer resetIncomingEmailPort()()
|
|
cfg, sec := makeBaseConfig()
|
|
|
|
// False is the default, but we test it explicitly.
|
|
sec.NewKey("USE_TLS", "false")
|
|
|
|
loadIncomingEmailFrom(cfg)
|
|
|
|
assert.EqualValues(t, 143, IncomingEmail.Port)
|
|
})
|
|
|
|
t.Run("no port, with tls", func(t *testing.T) {
|
|
defer resetIncomingEmailPort()()
|
|
cfg, sec := makeBaseConfig()
|
|
|
|
sec.NewKey("USE_TLS", "true")
|
|
|
|
loadIncomingEmailFrom(cfg)
|
|
|
|
assert.EqualValues(t, 993, IncomingEmail.Port)
|
|
})
|
|
|
|
t.Run("port overrides tls", func(t *testing.T) {
|
|
defer resetIncomingEmailPort()()
|
|
cfg, sec := makeBaseConfig()
|
|
|
|
sec.NewKey("PORT", "1993")
|
|
sec.NewKey("USE_TLS", "true")
|
|
|
|
loadIncomingEmailFrom(cfg)
|
|
|
|
assert.EqualValues(t, 1993, IncomingEmail.Port)
|
|
})
|
|
})
|
|
}
|