1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-11-22 08:42:32 -05:00
forgejo/services/repository/files
oliverpool 0fc61c8836 [BUG] split code conversations in diff tab (#2306)
Follow-up of #2282 and #2296 (which tried to address #2278)

One of the issue with the previous PR is that when a conversation on the Files tab was marked as "resolved", it would fetch all the comments for that line (even the outdated ones, which should not be shown on this page - except when explicitly activated).

To properly fix this, I have changed `FetchCodeCommentsByLine` to `FetchCodeConversation`. Its role is to fetch all comments related to a given (review, path, line) and reverted my changes in the template (which were based on a misunderstanding).

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2306
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: oliverpool <git@olivier.pfad.fr>
Co-committed-by: oliverpool <git@olivier.pfad.fr>
2024-02-16 12:16:11 +00:00
..
cherry_pick.go Fix reverting a merge commit failing (#28794) 2024-01-16 15:06:51 +00:00
commit.go Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
content.go [GITEA] Add download URL for executable files 2024-02-05 16:09:41 +01:00
content_test.go Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
diff.go Fix reverting a merge commit failing (#28794) 2024-01-16 15:06:51 +00:00
diff_test.go [BUG] split code conversations in diff tab (#2306) 2024-02-16 12:16:11 +00:00
file.go [GITEA] Allow user to select email for file operations in Web UI 2024-02-05 16:09:41 +01:00
file_test.go Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
patch.go Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
temp_repo.go Fix reverting a merge commit failing (#28794) 2024-01-16 15:06:51 +00:00
tree.go Abstract hash function usage (#28138) 2023-12-13 21:02:00 +00:00
tree_test.go Move web/api context related testing function into a separate package (#26859) 2023-09-01 11:26:07 +00:00
update.go Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
upload.go Fix reverting a merge commit failing (#28794) 2024-01-16 15:06:51 +00:00