mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-11-22 08:42:32 -05:00
4d22bda4db
A lot of existing packages do not conform to SemVer, yet, they should be allowed in the Conan package registry as-is. To achieve this, remove the SemVer check from `NewRecipeReference`, and replace it with a simple empty string check. A unit test with a non-semver version is also included. Fixes #20405. Signed-off-by: Gergely Nagy <me@gergo.csillger.hu> Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
156 lines
4 KiB
Go
156 lines
4 KiB
Go
// Copyright 2022 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package conan
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"regexp"
|
|
"strings"
|
|
|
|
"code.gitea.io/gitea/modules/log"
|
|
)
|
|
|
|
const (
|
|
// taken from https://github.com/conan-io/conan/blob/develop/conans/model/ref.py
|
|
minChars = 2
|
|
maxChars = 51
|
|
|
|
// DefaultRevision if no revision is specified
|
|
DefaultRevision = "0"
|
|
)
|
|
|
|
var (
|
|
namePattern = regexp.MustCompile(fmt.Sprintf(`^[a-zA-Z0-9_][a-zA-Z0-9_\+\.-]{%d,%d}$`, minChars-1, maxChars-1))
|
|
revisionPattern = regexp.MustCompile(fmt.Sprintf(`^[a-zA-Z0-9]{1,%d}$`, maxChars))
|
|
|
|
ErrValidation = errors.New("Could not validate one or more reference fields")
|
|
)
|
|
|
|
// RecipeReference represents a recipe <Name>/<Version>@<User>/<Channel>#<Revision>
|
|
type RecipeReference struct {
|
|
Name string
|
|
Version string
|
|
User string
|
|
Channel string
|
|
Revision string
|
|
}
|
|
|
|
func NewRecipeReference(name, version, user, channel, revision string) (*RecipeReference, error) {
|
|
log.Trace("Conan Recipe: %s/%s(@%s/%s(#%s))", name, version, user, channel, revision)
|
|
|
|
if user == "_" {
|
|
user = ""
|
|
}
|
|
if channel == "_" {
|
|
channel = ""
|
|
}
|
|
|
|
if (user != "" && channel == "") || (user == "" && channel != "") {
|
|
return nil, ErrValidation
|
|
}
|
|
|
|
if !namePattern.MatchString(name) {
|
|
return nil, ErrValidation
|
|
}
|
|
|
|
v := strings.TrimSpace(version)
|
|
if v == "" {
|
|
return nil, ErrValidation
|
|
}
|
|
if user != "" && !namePattern.MatchString(user) {
|
|
return nil, ErrValidation
|
|
}
|
|
if channel != "" && !namePattern.MatchString(channel) {
|
|
return nil, ErrValidation
|
|
}
|
|
if revision != "" && !revisionPattern.MatchString(revision) {
|
|
return nil, ErrValidation
|
|
}
|
|
|
|
return &RecipeReference{name, v, user, channel, revision}, nil
|
|
}
|
|
|
|
func (r *RecipeReference) RevisionOrDefault() string {
|
|
if r.Revision == "" {
|
|
return DefaultRevision
|
|
}
|
|
return r.Revision
|
|
}
|
|
|
|
func (r *RecipeReference) String() string {
|
|
rev := ""
|
|
if r.Revision != "" {
|
|
rev = "#" + r.Revision
|
|
}
|
|
if r.User == "" || r.Channel == "" {
|
|
return fmt.Sprintf("%s/%s%s", r.Name, r.Version, rev)
|
|
}
|
|
return fmt.Sprintf("%s/%s@%s/%s%s", r.Name, r.Version, r.User, r.Channel, rev)
|
|
}
|
|
|
|
func (r *RecipeReference) LinkName() string {
|
|
user := r.User
|
|
if user == "" {
|
|
user = "_"
|
|
}
|
|
channel := r.Channel
|
|
if channel == "" {
|
|
channel = "_"
|
|
}
|
|
return fmt.Sprintf("%s/%s/%s/%s/%s", r.Name, r.Version, user, channel, r.RevisionOrDefault())
|
|
}
|
|
|
|
func (r *RecipeReference) WithRevision(revision string) *RecipeReference {
|
|
return &RecipeReference{r.Name, r.Version, r.User, r.Channel, revision}
|
|
}
|
|
|
|
// AsKey builds the additional key for the package file
|
|
func (r *RecipeReference) AsKey() string {
|
|
return fmt.Sprintf("%s|%s|%s", r.User, r.Channel, r.RevisionOrDefault())
|
|
}
|
|
|
|
// PackageReference represents a package of a recipe <Name>/<Version>@<User>/<Channel>#<Revision> <Reference>#<Revision>
|
|
type PackageReference struct {
|
|
Recipe *RecipeReference
|
|
Reference string
|
|
Revision string
|
|
}
|
|
|
|
func NewPackageReference(recipe *RecipeReference, reference, revision string) (*PackageReference, error) {
|
|
log.Trace("Conan Package: %v %s(#%s)", recipe, reference, revision)
|
|
|
|
if recipe == nil {
|
|
return nil, ErrValidation
|
|
}
|
|
if reference == "" || !revisionPattern.MatchString(reference) {
|
|
return nil, ErrValidation
|
|
}
|
|
if revision != "" && !revisionPattern.MatchString(revision) {
|
|
return nil, ErrValidation
|
|
}
|
|
|
|
return &PackageReference{recipe, reference, revision}, nil
|
|
}
|
|
|
|
func (r *PackageReference) RevisionOrDefault() string {
|
|
if r.Revision == "" {
|
|
return DefaultRevision
|
|
}
|
|
return r.Revision
|
|
}
|
|
|
|
func (r *PackageReference) LinkName() string {
|
|
return fmt.Sprintf("%s/%s", r.Reference, r.RevisionOrDefault())
|
|
}
|
|
|
|
func (r *PackageReference) WithRevision(revision string) *PackageReference {
|
|
return &PackageReference{r.Recipe, r.Reference, revision}
|
|
}
|
|
|
|
// AsKey builds the additional key for the package file
|
|
func (r *PackageReference) AsKey() string {
|
|
return fmt.Sprintf("%s|%s|%s|%s|%s", r.Recipe.User, r.Recipe.Channel, r.Recipe.RevisionOrDefault(), r.Reference, r.RevisionOrDefault())
|
|
}
|