mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-28 13:49:13 -05:00
6433ba0ec3
Use [chi](https://github.com/go-chi/chi) instead of the forked [macaron](https://gitea.com/macaron/macaron). Since macaron and chi have conflicts with session share, this big PR becomes a have-to thing. According my previous idea, we can replace macaron step by step but I'm wrong. :( Below is a list of big changes on this PR. - [x] Define `context.ResponseWriter` interface with an implementation `context.Response`. - [x] Use chi instead of macaron, and also a customize `Route` to wrap chi so that the router usage is similar as before. - [x] Create different routers for `web`, `api`, `internal` and `install` so that the codes will be more clear and no magic . - [x] Use https://github.com/unrolled/render instead of macaron's internal render - [x] Use https://github.com/NYTimes/gziphandler instead of https://gitea.com/macaron/gzip - [x] Use https://gitea.com/go-chi/session which is a modified version of https://gitea.com/macaron/session and removed `nodb` support since it will not be maintained. **BREAK** - [x] Use https://gitea.com/go-chi/captcha which is a modified version of https://gitea.com/macaron/captcha - [x] Use https://gitea.com/go-chi/cache which is a modified version of https://gitea.com/macaron/cache - [x] Use https://gitea.com/go-chi/binding which is a modified version of https://gitea.com/macaron/binding - [x] Use https://github.com/go-chi/cors instead of https://gitea.com/macaron/cors - [x] Dropped https://gitea.com/macaron/i18n and make a new one in `code.gitea.io/gitea/modules/translation` - [x] Move validation form structs from `code.gitea.io/gitea/modules/auth` to `code.gitea.io/gitea/modules/forms` to avoid dependency cycle. - [x] Removed macaron log service because it's not need any more. **BREAK** - [x] All form structs have to be get by `web.GetForm(ctx)` in the route function but not as a function parameter on routes definition. - [x] Move Git HTTP protocol implementation to use routers directly. - [x] Fix the problem that chi routes don't support trailing slash but macaron did. - [x] `/api/v1/swagger` now will be redirect to `/api/swagger` but not render directly so that `APIContext` will not create a html render. Notices: - Chi router don't support request with trailing slash - Integration test `TestUserHeatmap` maybe mysql version related. It's failed on my macOS(mysql 5.7.29 installed via brew) but succeed on CI. Co-authored-by: 6543 <6543@obermui.de>
215 lines
6.1 KiB
Go
215 lines
6.1 KiB
Go
// Copyright 2017 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package repo
|
|
|
|
import (
|
|
"io/ioutil"
|
|
"net/http"
|
|
"testing"
|
|
|
|
"code.gitea.io/gitea/models"
|
|
auth "code.gitea.io/gitea/modules/forms"
|
|
"code.gitea.io/gitea/modules/git"
|
|
"code.gitea.io/gitea/modules/test"
|
|
"code.gitea.io/gitea/modules/web"
|
|
wiki_service "code.gitea.io/gitea/services/wiki"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
const content = "Wiki contents for unit tests"
|
|
const message = "Wiki commit message for unit tests"
|
|
|
|
func wikiEntry(t *testing.T, repo *models.Repository, wikiName string) *git.TreeEntry {
|
|
wikiRepo, err := git.OpenRepository(repo.WikiPath())
|
|
assert.NoError(t, err)
|
|
defer wikiRepo.Close()
|
|
commit, err := wikiRepo.GetBranchCommit("master")
|
|
assert.NoError(t, err)
|
|
entries, err := commit.ListEntries()
|
|
assert.NoError(t, err)
|
|
for _, entry := range entries {
|
|
if entry.Name() == wiki_service.NameToFilename(wikiName) {
|
|
return entry
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func wikiContent(t *testing.T, repo *models.Repository, wikiName string) string {
|
|
entry := wikiEntry(t, repo, wikiName)
|
|
if !assert.NotNil(t, entry) {
|
|
return ""
|
|
}
|
|
reader, err := entry.Blob().DataAsync()
|
|
assert.NoError(t, err)
|
|
defer reader.Close()
|
|
bytes, err := ioutil.ReadAll(reader)
|
|
assert.NoError(t, err)
|
|
return string(bytes)
|
|
}
|
|
|
|
func assertWikiExists(t *testing.T, repo *models.Repository, wikiName string) {
|
|
assert.NotNil(t, wikiEntry(t, repo, wikiName))
|
|
}
|
|
|
|
func assertWikiNotExists(t *testing.T, repo *models.Repository, wikiName string) {
|
|
assert.Nil(t, wikiEntry(t, repo, wikiName))
|
|
}
|
|
|
|
func assertPagesMetas(t *testing.T, expectedNames []string, metas interface{}) {
|
|
pageMetas, ok := metas.([]PageMeta)
|
|
if !assert.True(t, ok) {
|
|
return
|
|
}
|
|
if !assert.EqualValues(t, len(expectedNames), len(pageMetas)) {
|
|
return
|
|
}
|
|
for i, pageMeta := range pageMetas {
|
|
assert.EqualValues(t, expectedNames[i], pageMeta.Name)
|
|
}
|
|
}
|
|
|
|
func TestWiki(t *testing.T) {
|
|
models.PrepareTestEnv(t)
|
|
|
|
ctx := test.MockContext(t, "user2/repo1/wiki/_pages")
|
|
ctx.SetParams(":page", "Home")
|
|
test.LoadRepo(t, ctx, 1)
|
|
Wiki(ctx)
|
|
assert.EqualValues(t, http.StatusOK, ctx.Resp.Status())
|
|
assert.EqualValues(t, "Home", ctx.Data["Title"])
|
|
assertPagesMetas(t, []string{"Home", "Page With Image", "Page With Spaced Name"}, ctx.Data["Pages"])
|
|
}
|
|
|
|
func TestWikiPages(t *testing.T) {
|
|
models.PrepareTestEnv(t)
|
|
|
|
ctx := test.MockContext(t, "user2/repo1/wiki/_pages")
|
|
test.LoadRepo(t, ctx, 1)
|
|
WikiPages(ctx)
|
|
assert.EqualValues(t, http.StatusOK, ctx.Resp.Status())
|
|
assertPagesMetas(t, []string{"Home", "Page With Image", "Page With Spaced Name"}, ctx.Data["Pages"])
|
|
}
|
|
|
|
func TestNewWiki(t *testing.T) {
|
|
models.PrepareTestEnv(t)
|
|
|
|
ctx := test.MockContext(t, "user2/repo1/wiki/_new")
|
|
test.LoadUser(t, ctx, 2)
|
|
test.LoadRepo(t, ctx, 1)
|
|
NewWiki(ctx)
|
|
assert.EqualValues(t, http.StatusOK, ctx.Resp.Status())
|
|
assert.EqualValues(t, ctx.Tr("repo.wiki.new_page"), ctx.Data["Title"])
|
|
}
|
|
|
|
func TestNewWikiPost(t *testing.T) {
|
|
for _, title := range []string{
|
|
"New page",
|
|
"&&&&",
|
|
} {
|
|
models.PrepareTestEnv(t)
|
|
|
|
ctx := test.MockContext(t, "user2/repo1/wiki/_new")
|
|
test.LoadUser(t, ctx, 2)
|
|
test.LoadRepo(t, ctx, 1)
|
|
web.SetForm(ctx, &auth.NewWikiForm{
|
|
Title: title,
|
|
Content: content,
|
|
Message: message,
|
|
})
|
|
NewWikiPost(ctx)
|
|
assert.EqualValues(t, http.StatusFound, ctx.Resp.Status())
|
|
assertWikiExists(t, ctx.Repo.Repository, title)
|
|
assert.Equal(t, wikiContent(t, ctx.Repo.Repository, title), content)
|
|
}
|
|
}
|
|
|
|
func TestNewWikiPost_ReservedName(t *testing.T) {
|
|
models.PrepareTestEnv(t)
|
|
|
|
ctx := test.MockContext(t, "user2/repo1/wiki/_new")
|
|
test.LoadUser(t, ctx, 2)
|
|
test.LoadRepo(t, ctx, 1)
|
|
web.SetForm(ctx, &auth.NewWikiForm{
|
|
Title: "_edit",
|
|
Content: content,
|
|
Message: message,
|
|
})
|
|
NewWikiPost(ctx)
|
|
assert.EqualValues(t, http.StatusOK, ctx.Resp.Status())
|
|
assert.EqualValues(t, ctx.Tr("repo.wiki.reserved_page"), ctx.Flash.ErrorMsg)
|
|
assertWikiNotExists(t, ctx.Repo.Repository, "_edit")
|
|
}
|
|
|
|
func TestEditWiki(t *testing.T) {
|
|
models.PrepareTestEnv(t)
|
|
|
|
ctx := test.MockContext(t, "user2/repo1/wiki/_edit/Home")
|
|
ctx.SetParams(":page", "Home")
|
|
test.LoadUser(t, ctx, 2)
|
|
test.LoadRepo(t, ctx, 1)
|
|
EditWiki(ctx)
|
|
assert.EqualValues(t, http.StatusOK, ctx.Resp.Status())
|
|
assert.EqualValues(t, "Home", ctx.Data["Title"])
|
|
assert.Equal(t, wikiContent(t, ctx.Repo.Repository, "Home"), ctx.Data["content"])
|
|
}
|
|
|
|
func TestEditWikiPost(t *testing.T) {
|
|
for _, title := range []string{
|
|
"Home",
|
|
"New/<page>",
|
|
} {
|
|
models.PrepareTestEnv(t)
|
|
ctx := test.MockContext(t, "user2/repo1/wiki/_new/Home")
|
|
ctx.SetParams(":page", "Home")
|
|
test.LoadUser(t, ctx, 2)
|
|
test.LoadRepo(t, ctx, 1)
|
|
web.SetForm(ctx, &auth.NewWikiForm{
|
|
Title: title,
|
|
Content: content,
|
|
Message: message,
|
|
})
|
|
EditWikiPost(ctx)
|
|
assert.EqualValues(t, http.StatusFound, ctx.Resp.Status())
|
|
assertWikiExists(t, ctx.Repo.Repository, title)
|
|
assert.Equal(t, wikiContent(t, ctx.Repo.Repository, title), content)
|
|
if title != "Home" {
|
|
assertWikiNotExists(t, ctx.Repo.Repository, "Home")
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestDeleteWikiPagePost(t *testing.T) {
|
|
models.PrepareTestEnv(t)
|
|
|
|
ctx := test.MockContext(t, "user2/repo1/wiki/Home/delete")
|
|
test.LoadUser(t, ctx, 2)
|
|
test.LoadRepo(t, ctx, 1)
|
|
DeleteWikiPagePost(ctx)
|
|
assert.EqualValues(t, http.StatusOK, ctx.Resp.Status())
|
|
assertWikiNotExists(t, ctx.Repo.Repository, "Home")
|
|
}
|
|
|
|
func TestWikiRaw(t *testing.T) {
|
|
for filepath, filetype := range map[string]string{
|
|
"jpeg.jpg": "image/jpeg",
|
|
"images/jpeg.jpg": "image/jpeg",
|
|
"Page With Spaced Name": "text/plain; charset=utf-8",
|
|
"Page-With-Spaced-Name": "text/plain; charset=utf-8",
|
|
"Page With Spaced Name.md": "text/plain; charset=utf-8",
|
|
"Page-With-Spaced-Name.md": "text/plain; charset=utf-8",
|
|
} {
|
|
models.PrepareTestEnv(t)
|
|
|
|
ctx := test.MockContext(t, "user2/repo1/wiki/raw/"+filepath)
|
|
ctx.SetParams("*", filepath)
|
|
test.LoadUser(t, ctx, 2)
|
|
test.LoadRepo(t, ctx, 1)
|
|
WikiRaw(ctx)
|
|
assert.EqualValues(t, http.StatusOK, ctx.Resp.Status())
|
|
assert.EqualValues(t, filetype, ctx.Resp.Header().Get("Content-Type"))
|
|
}
|
|
}
|