mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-11-25 08:59:31 -05:00
de484e86bc
This PR adds the support for scopes of access tokens, mimicking the design of GitHub OAuth scopes. The changes of the core logic are in `models/auth` that `AccessToken` struct will have a `Scope` field. The normalized (no duplication of scope), comma-separated scope string will be stored in `access_token` table in the database. In `services/auth`, the scope will be stored in context, which will be used by `reqToken` middleware in API calls. Only OAuth2 tokens will have granular token scopes, while others like BasicAuth will default to scope `all`. A large amount of work happens in `routers/api/v1/api.go` and the corresponding `tests/integration` tests, that is adding necessary scopes to each of the API calls as they fit. - [x] Add `Scope` field to `AccessToken` - [x] Add access control to all API endpoints - [x] Update frontend & backend for when creating tokens - [x] Add a database migration for `scope` column (enable 'all' access to past tokens) I'm aiming to complete it before Gitea 1.19 release. Fixes #4300
84 lines
2.5 KiB
Go
84 lines
2.5 KiB
Go
// Copyright 2020 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package integration
|
|
|
|
import (
|
|
"fmt"
|
|
"net/http"
|
|
"testing"
|
|
"time"
|
|
|
|
activities_model "code.gitea.io/gitea/models/activities"
|
|
auth_model "code.gitea.io/gitea/models/auth"
|
|
"code.gitea.io/gitea/models/db"
|
|
repo_model "code.gitea.io/gitea/models/repo"
|
|
"code.gitea.io/gitea/models/unittest"
|
|
user_model "code.gitea.io/gitea/models/user"
|
|
"code.gitea.io/gitea/modules/eventsource"
|
|
api "code.gitea.io/gitea/modules/structs"
|
|
"code.gitea.io/gitea/tests"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestEventSourceManagerRun(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
manager := eventsource.GetManager()
|
|
|
|
eventChan := manager.Register(2)
|
|
defer func() {
|
|
manager.Unregister(2, eventChan)
|
|
// ensure the eventChan is closed
|
|
for {
|
|
_, ok := <-eventChan
|
|
if !ok {
|
|
break
|
|
}
|
|
}
|
|
}()
|
|
expectNotificationCountEvent := func(count int64) func() bool {
|
|
return func() bool {
|
|
select {
|
|
case event, ok := <-eventChan:
|
|
if !ok {
|
|
return false
|
|
}
|
|
data, ok := event.Data.(activities_model.UserIDCount)
|
|
if !ok {
|
|
return false
|
|
}
|
|
return event.Name == "notification-count" && data.Count == count
|
|
default:
|
|
return false
|
|
}
|
|
}
|
|
}
|
|
|
|
user2 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
|
repo1 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
|
|
thread5 := unittest.AssertExistsAndLoadBean(t, &activities_model.Notification{ID: 5})
|
|
assert.NoError(t, thread5.LoadAttributes(db.DefaultContext))
|
|
session := loginUser(t, user2.Name)
|
|
token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeNotification)
|
|
|
|
var apiNL []api.NotificationThread
|
|
|
|
// -- mark notifications as read --
|
|
req := NewRequest(t, "GET", fmt.Sprintf("/api/v1/notifications?status-types=unread&token=%s", token))
|
|
resp := session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
DecodeJSON(t, resp, &apiNL)
|
|
assert.Len(t, apiNL, 2)
|
|
|
|
lastReadAt := "2000-01-01T00%3A50%3A01%2B00%3A00" // 946687801 <- only Notification 4 is in this filter ...
|
|
req = NewRequest(t, "PUT", fmt.Sprintf("/api/v1/repos/%s/%s/notifications?last_read_at=%s&token=%s", user2.Name, repo1.Name, lastReadAt, token))
|
|
session.MakeRequest(t, req, http.StatusResetContent)
|
|
|
|
req = NewRequest(t, "GET", fmt.Sprintf("/api/v1/notifications?token=%s&status-types=unread", token))
|
|
resp = session.MakeRequest(t, req, http.StatusOK)
|
|
DecodeJSON(t, resp, &apiNL)
|
|
assert.Len(t, apiNL, 1)
|
|
|
|
assert.Eventually(t, expectNotificationCountEvent(1), 30*time.Second, 1*time.Second)
|
|
}
|