foster/forgejo
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-11-27 09:11:53 -05:00
Code Issues Wiki Activity
forgejo/cmd
History
emilylange f01dc4b271 test(dump): don't depend on directory listing order 
cmd/dump.go uses os.Readdir to list the directory.

This is fine on its own, but TestAddRecursiveExclude in cmd/dump_test.go
depends on the order of the directory listing, which is where the issue
lays.

Directory listings using os.Readdir (lstat) don't actually guarantee an
order. They can differ due to a number of factors. Most notably the OS,
file system and settings.

As such, the test should not check the /order of the files/ added to the
archive, but instead simply check whether the archive /contains/ them.

So this is precisely what this commit does.

Note that only TestAddRecursiveExclude/File_inside_directory/No_exclude
has been observed to fail due to this, but all TestAddRecursiveExclude
subtests have been updated for consistency.

(cherry picked from commit 230a677c74)
2024-06-17 18:53:34 +00:00
..
forgejo [REFACTOR] cli: prepareWorkPathAndCustomConf is not just for actions 2024-02-25 09:54:25 +01:00
actions.go [BRANDING] cosmetic s/Gitea/Forgejo/ in logs, messages, etc. 2024-02-05 16:02:14 +01:00
admin.go Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
admin_auth.go Use db.Find instead of writing methods for every object (#28084) 2023-11-24 03:49:41 +00:00
admin_auth_ldap.go Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
admin_auth_ldap_test.go Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
admin_auth_oauth.go Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
admin_auth_stmp.go Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
admin_regenerate.go Revert "[BUG] Initalize Git for hook regeneration" 2024-02-26 22:30:25 +01:00
admin_user.go Refactor to use urfave/cli/v2 (#25959) 2023-07-21 17:28:19 +08:00
admin_user_change_password.go Improve "must-change-password" logic and document (#30472) 2024-04-21 17:44:11 +02:00
admin_user_create.go fix(cli): admin user create first user never require a password change 2024-04-24 22:26:37 +00:00
admin_user_delete.go Refactor to use urfave/cli/v2 (#25959) 2023-07-21 17:28:19 +08:00
admin_user_generate_access_token.go More refactoring of db.DefaultContext (#27083) 2023-09-15 06:13:19 +00:00
admin_user_list.go Reduce usage of db.DefaultContext (#27073) 2023-09-14 17:09:32 +00:00
admin_user_must_change_password.go Refactor to use urfave/cli/v2 (#25959) 2023-07-21 17:28:19 +08:00
cert.go [BRANDING] cosmetic s/Gitea/Forgejo/ in logs, messages, etc. 2024-02-05 16:02:14 +01:00
cmd.go Refactor to use urfave/cli/v2 (#25959) 2023-07-21 17:28:19 +08:00
docs.go [BRANDING] cosmetic s/Gitea/Forgejo/ in logs, messages, etc. 2024-02-05 16:02:14 +01:00
doctor.go [BRANDING] cosmetic s/Gitea/Forgejo/ in logs, messages, etc. 2024-02-05 16:02:14 +01:00
doctor_convert.go Recommend/convert to use case-sensitive collation for MySQL/MSSQL (#28662) 2024-01-10 11:03:23 +00:00
doctor_test.go Move doctor package from modules to services (#28856) 2024-01-20 10:07:31 +08:00
dump.go [BUG] Allow to exclude files in dump 2024-03-29 13:25:11 +01:00
dump_repo.go Refactor to use urfave/cli/v2 (#25959) 2023-07-21 17:28:19 +08:00
dump_test.go test(dump): don't depend on directory listing order 2024-06-17 18:53:34 +00:00
embedded.go Refactor to use urfave/cli/v2 (#25959) 2023-07-21 17:28:19 +08:00
generate.go [GITEA] Refactor generation of JWT secret 2024-02-05 16:54:44 +01:00
hook.go Merge pull request '[gitea] week 2024-20-v7.0 cherry pick (release/v1.22 -> v7.0/forgejo)' (#3772) from earl-warren/wcp/2024-20-v7.0 into v7.0/forgejo 2024-05-16 15:36:08 +00:00
hook_test.go Add unit tests for update git hook 2024-04-06 17:39:03 +00:00
keys.go Refactor cmd setup and remove deadcode (#29313) 2024-02-26 22:30:25 +01:00
mailer.go Return responseText instead of string in some functions (#28836) 2024-01-19 10:45:23 +08:00
main.go [BRANDING] alias {FORGEJO,GITEA}_{CUSTOM,WORK_DIR} 2024-02-05 16:05:01 +01:00
main_test.go make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
manager.go [BRANDING] cosmetic s/Gitea/Forgejo/ in logs, messages, etc. 2024-02-05 16:02:14 +01:00
manager_logging.go [BRANDING] cosmetic s/Gitea/Forgejo/ in logs, messages, etc. 2024-02-05 16:02:14 +01:00
migrate.go Refactor to use urfave/cli/v2 (#25959) 2023-07-21 17:28:19 +08:00
migrate_storage.go tests(cmd): add coverage for migrateActionsArtifacts 2024-06-09 14:55:01 +00:00
migrate_storage_test.go tests(cmd): add coverage for migrateActionsArtifacts 2024-06-09 14:55:01 +00:00
restore_repo.go Refactor to use urfave/cli/v2 (#25959) 2023-07-21 17:28:19 +08:00
serv.go [REFACTOR] PKT protocol 2024-03-29 00:53:04 +01:00
web.go Clean up log messages (#30313) 2024-04-15 16:11:14 +02:00
web_acme.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
web_graceful.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
web_https.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00