1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-22 12:54:53 -05:00
forgejo/services/repository/files
oliverpool 07bc099401 [BUG] split code conversations in diff tab (#2306)
Follow-up of #2282 and #2296 (which tried to address #2278)

One of the issue with the previous PR is that when a conversation on the Files tab was marked as "resolved", it would fetch all the comments for that line (even the outdated ones, which should not be shown on this page - except when explicitly activated).

To properly fix this, I have changed `FetchCodeCommentsByLine` to `FetchCodeConversation`. Its role is to fetch all comments related to a given (review, path, line) and reverted my changes in the template (which were based on a misunderstanding).

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2306
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: oliverpool <git@olivier.pfad.fr>
Co-committed-by: oliverpool <git@olivier.pfad.fr>
2024-02-16 14:06:43 +01:00
..
cherry_pick.go Fix reverting a merge commit failing (#28794) (#28825) 2024-01-31 14:18:25 +01:00
commit.go Add context cache as a request level cache (#22294) 2023-02-15 21:37:34 +08:00
content.go [GITEA] Add download URL for executable files 2023-12-04 17:19:13 +00:00
content_test.go move repository deletion to service layer (#26948) 2023-09-08 04:51:15 +00:00
diff.go Fix reverting a merge commit failing (#28794) (#28825) 2024-01-31 14:18:25 +01:00
diff_test.go [BUG] split code conversations in diff tab (#2306) 2024-02-16 14:06:43 +01:00
file.go API endpoint for changing/creating/deleting multiple files (#24887) 2023-05-29 17:41:35 +08:00
file_test.go Move web/api context related testing function into a separate package (#26859) 2023-09-01 11:26:07 +00:00
patch.go Fix reverting a merge commit failing (#28794) (#28825) 2024-01-31 14:18:25 +01:00
temp_repo.go Fix reverting a merge commit failing (#28794) (#28825) 2024-01-31 14:18:25 +01:00
tree.go Return empty url for submodule tree entries (#23043) 2023-02-21 12:31:17 -05:00
tree_test.go Move web/api context related testing function into a separate package (#26859) 2023-09-01 11:26:07 +00:00
update.go Fix reverting a merge commit failing (#28794) (#28825) 2024-01-31 14:18:25 +01:00
upload.go Fix reverting a merge commit failing (#28794) (#28825) 2024-01-31 14:18:25 +01:00