mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-11-25 08:59:31 -05:00
a94a8d0ab1
`http.ServeFile/ServeContent` handles `If-xxx`, `Content-Length`, `Range` and `Etag` correctly After this PR, storage files (eg: avatar) could be responded with correct Content-Length.
97 lines
2.7 KiB
Go
97 lines
2.7 KiB
Go
// Copyright 2021 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package httpcache
|
|
|
|
import (
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func countFormalHeaders(h http.Header) (c int) {
|
|
for k := range h {
|
|
// ignore our headers for internal usage
|
|
if strings.HasPrefix(k, "X-Gitea-") {
|
|
continue
|
|
}
|
|
c++
|
|
}
|
|
return c
|
|
}
|
|
|
|
func TestHandleGenericETagCache(t *testing.T) {
|
|
etag := `"test"`
|
|
|
|
t.Run("No_If-None-Match", func(t *testing.T) {
|
|
req := &http.Request{Header: make(http.Header)}
|
|
w := httptest.NewRecorder()
|
|
|
|
handled := HandleGenericETagCache(req, w, etag)
|
|
|
|
assert.False(t, handled)
|
|
assert.Equal(t, 2, countFormalHeaders(w.Header()))
|
|
assert.Contains(t, w.Header(), "Cache-Control")
|
|
assert.Contains(t, w.Header(), "Etag")
|
|
assert.Equal(t, etag, w.Header().Get("Etag"))
|
|
})
|
|
t.Run("Wrong_If-None-Match", func(t *testing.T) {
|
|
req := &http.Request{Header: make(http.Header)}
|
|
w := httptest.NewRecorder()
|
|
|
|
req.Header.Set("If-None-Match", `"wrong etag"`)
|
|
|
|
handled := HandleGenericETagCache(req, w, etag)
|
|
|
|
assert.False(t, handled)
|
|
assert.Equal(t, 2, countFormalHeaders(w.Header()))
|
|
assert.Contains(t, w.Header(), "Cache-Control")
|
|
assert.Contains(t, w.Header(), "Etag")
|
|
assert.Equal(t, etag, w.Header().Get("Etag"))
|
|
})
|
|
t.Run("Correct_If-None-Match", func(t *testing.T) {
|
|
req := &http.Request{Header: make(http.Header)}
|
|
w := httptest.NewRecorder()
|
|
|
|
req.Header.Set("If-None-Match", etag)
|
|
|
|
handled := HandleGenericETagCache(req, w, etag)
|
|
|
|
assert.True(t, handled)
|
|
assert.Equal(t, 1, countFormalHeaders(w.Header()))
|
|
assert.Contains(t, w.Header(), "Etag")
|
|
assert.Equal(t, etag, w.Header().Get("Etag"))
|
|
assert.Equal(t, http.StatusNotModified, w.Code)
|
|
})
|
|
t.Run("Multiple_Wrong_If-None-Match", func(t *testing.T) {
|
|
req := &http.Request{Header: make(http.Header)}
|
|
w := httptest.NewRecorder()
|
|
|
|
req.Header.Set("If-None-Match", `"wrong etag", "wrong etag "`)
|
|
|
|
handled := HandleGenericETagCache(req, w, etag)
|
|
|
|
assert.False(t, handled)
|
|
assert.Equal(t, 2, countFormalHeaders(w.Header()))
|
|
assert.Contains(t, w.Header(), "Cache-Control")
|
|
assert.Contains(t, w.Header(), "Etag")
|
|
assert.Equal(t, etag, w.Header().Get("Etag"))
|
|
})
|
|
t.Run("Multiple_Correct_If-None-Match", func(t *testing.T) {
|
|
req := &http.Request{Header: make(http.Header)}
|
|
w := httptest.NewRecorder()
|
|
|
|
req.Header.Set("If-None-Match", `"wrong etag", `+etag)
|
|
|
|
handled := HandleGenericETagCache(req, w, etag)
|
|
|
|
assert.True(t, handled)
|
|
assert.Equal(t, 1, countFormalHeaders(w.Header()))
|
|
assert.Contains(t, w.Header(), "Etag")
|
|
assert.Equal(t, etag, w.Header().Get("Etag"))
|
|
assert.Equal(t, http.StatusNotModified, w.Code)
|
|
})
|
|
}
|