mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-11-29 09:31:11 -05:00
b6e81357bd
_This is a different approach to #20267, I took the liberty of adapting some parts, see below_ ## Context In some cases, a weebhook endpoint requires some kind of authentication. The usual way is by sending a static `Authorization` header, with a given token. For instance: - Matrix expects a `Bearer <token>` (already implemented, by storing the header cleartext in the metadata - which is buggy on retry #19872) - TeamCity #18667 - Gitea instances #20267 - SourceHut https://man.sr.ht/graphql.md#authentication-strategies (this is my actual personal need :) ## Proposed solution Add a dedicated encrypt column to the webhook table (instead of storing it as meta as proposed in #20267), so that it gets available for all present and future hook types (especially the custom ones #19307). This would also solve the buggy matrix retry #19872. As a first step, I would recommend focusing on the backend logic and improve the frontend at a later stage. For now the UI is a simple `Authorization` field (which could be later customized with `Bearer` and `Basic` switches):  The header name is hard-coded, since I couldn't fine any usecase justifying otherwise. ## Questions - What do you think of this approach? @justusbunsi @Gusted @silverwind - ~~How are the migrations generated? Do I have to manually create a new file, or is there a command for that?~~ - ~~I started adding it to the API: should I complete it or should I drop it? (I don't know how much the API is actually used)~~ ## Done as well: - add a migration for the existing matrix webhooks and remove the `Authorization` logic there _Closes #19872_ Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Gusted <williamzijl7@hotmail.com> Co-authored-by: delvh <dev.lh@web.de> |
||
|---|---|---|
| .. | ||
| locale_bg-BG.ini | ||
| locale_cs-CZ.ini | ||
| locale_de-DE.ini | ||
| locale_el-GR.ini | ||
| locale_en-US.ini | ||
| locale_es-ES.ini | ||
| locale_fa-IR.ini | ||
| locale_fi-FI.ini | ||
| locale_fr-FR.ini | ||
| locale_hu-HU.ini | ||
| locale_id-ID.ini | ||
| locale_is-IS.ini | ||
| locale_it-IT.ini | ||
| locale_ja-JP.ini | ||
| locale_ko-KR.ini | ||
| locale_lv-LV.ini | ||
| locale_ml-IN.ini | ||
| locale_nl-NL.ini | ||
| locale_pl-PL.ini | ||
| locale_pt-BR.ini | ||
| locale_pt-PT.ini | ||
| locale_ru-RU.ini | ||
| locale_si-LK.ini | ||
| locale_sk-SK.ini | ||
| locale_sv-SE.ini | ||
| locale_tr-TR.ini | ||
| locale_uk-UA.ini | ||
| locale_zh-CN.ini | ||
| locale_zh-HK.ini | ||
| locale_zh-TW.ini | ||
| TRANSLATORS | ||
