1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-02 10:07:07 -05:00
forgejo/routers
Lunny Xiao 900e158064
refactor auth interface to return error when verify failure (#22119) (#22259)
backport #22119

This PR changed the Auth interface signature from `Verify(http
*http.Request, w http.ResponseWriter, store DataStore, sess
SessionStore) *user_model.User`
to 
`Verify(http *http.Request, w http.ResponseWriter, store DataStore, sess
SessionStore) (*user_model.User, error)`.

There is a new return argument `error` which means the verification
condition matched but verify process failed, we should stop the auth
process.

Before this PR, when return a `nil` user, we don't know the reason why
it returned `nil`. If the match condition is not satisfied or it
verified failure? For these two different results, we should have
different handler. If the match condition is not satisfied, we should
try next auth method and if there is no more auth method, it's an
anonymous user. If the condition matched but verify failed, the auth
process should be stop and return immediately.

This will fix #20563

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: Jason Song <i@wolfogre.com>
2022-12-29 13:50:09 +08:00
..
api refactor auth interface to return error when verify failure (#22119) (#22259) 2022-12-29 13:50:09 +08:00
common Add support for HEAD requests in Maven registry (#21834) (#21929) 2022-11-25 13:46:28 +02:00
install Fix token generation when using INTERNAL_TOKEN_URI (#21669) (#21670) 2022-11-03 20:54:25 +00:00
private Refactor git command arguments and make all arguments to be safe to be used (#21535) 2022-10-23 22:44:45 +08:00
utils refactor webhook *NewPost (#20729) 2022-08-11 17:48:23 +02:00
web Use complete SHA to create and query commit status (#22244) (#22257) 2022-12-28 11:03:21 +01:00
init.go Sync git hooks when config file path changed (#21619) (#21626) 2022-10-30 11:17:11 +08:00