1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-22 12:54:53 -05:00
forgejo/models/issues
sebastian-sauer 55532061c8
Add commits dropdown in PR files view and allow commit by commit review (#25528)
This PR adds a new dropdown to select a commit or a commit range
(shift-click like github) of a Pull Request.
After selection of a commit only the changes of this commit will be shown.
When selecting a range of commits the diff of this range is shown.

This allows to review a PR commit by commit or by viewing only commit ranges.
The "Show changes since your last review" mechanism github uses is implemented, too.
When reviewing a single commit or a commit range the "Viewed" functionality is disabled.

## Screenshots

### The commit dropdown

![image](https://github.com/go-gitea/gitea/assets/51889757/0db3ae62-1272-436c-be64-4730c5d611e3)

### Selecting a commit range

![image](https://github.com/go-gitea/gitea/assets/51889757/ad81eedb-8437-42b0-8073-2d940c25fe8f)

### Show changes of a single commit only

![image](https://github.com/go-gitea/gitea/assets/51889757/6b1a113b-73ef-4ecc-adf6-bc2340bb8f97)

### Show changes of a commit range

![image](https://github.com/go-gitea/gitea/assets/51889757/6401b358-cd66-4c09-8baa-6cf6177f23a7)


Fixes https://github.com/go-gitea/gitea/issues/20989
Fixes https://github.com/go-gitea/gitea/issues/19263

---------

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: delvh <dev.lh@web.de>
2023-07-28 21:18:12 +02:00
..
assignees.go Make more functions use ctx instead of db.DefaultContext (#24068) 2023-04-14 14:18:28 -04:00
assignees_test.go Make more functions use ctx instead of db.DefaultContext (#24068) 2023-04-14 14:18:28 -04:00
comment.go Update tool dependencies, lock govulncheck and actionlint (#25655) 2023-07-09 11:58:06 +00:00
comment_code.go Show outdated comments in files changed tab (#24936) 2023-06-21 16:08:12 +00:00
comment_list.go Add context parameter to some database functions (#26055) 2023-07-22 22:14:27 +08:00
comment_test.go Show outdated comments in files changed tab (#24936) 2023-06-21 16:08:12 +00:00
content_history.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
content_history_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
dependency.go Add API to manage issue dependencies (#17935) 2023-03-28 13:23:25 -04:00
dependency_test.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
issue.go Add context parameter to some database functions (#26055) 2023-07-22 22:14:27 +08:00
issue_index.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue_label.go Update tool dependencies, lock govulncheck and actionlint (#25655) 2023-07-09 11:58:06 +00:00
issue_list.go Add context parameter to some database functions (#26055) 2023-07-22 22:14:27 +08:00
issue_list_test.go Add context parameter to some database functions (#26055) 2023-07-22 22:14:27 +08:00
issue_lock.go Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
issue_project.go Fix empty project displayed in issue sidebar (#25802) 2023-07-12 16:10:35 +02:00
issue_search.go Add context parameter to some database functions (#26055) 2023-07-22 22:14:27 +08:00
issue_stats.go Fix 500 error when select No assignee filter in issue list page (#24854) 2023-05-22 13:08:27 +02:00
issue_test.go Add commits dropdown in PR files view and allow commit by commit review (#25528) 2023-07-28 21:18:12 +02:00
issue_update.go Update tool dependencies, lock govulncheck and actionlint (#25655) 2023-07-09 11:58:06 +00:00
issue_user.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue_user_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue_watch.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue_watch_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue_xref.go Fix more HTMLURL in templates (#22831) 2023-02-09 11:31:30 -05:00
issue_xref_test.go Make more functions use ctx instead of db.DefaultContext (#24068) 2023-04-14 14:18:28 -04:00
label.go Some refactors for issues stats (#24793) 2023-05-19 22:17:48 +08:00
label_test.go Modify luminance calculation and extract related functions into single files (#24586) 2023-05-10 11:19:03 +00:00
main_test.go Merge setting.InitXXX into one function with options (#24389) 2023-05-04 11:55:35 +08:00
milestone.go Localize milestone related time strings (#24051) 2023-04-12 02:29:49 -04:00
milestone_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
pull.go Fix bug when pushing to a pull request which enabled dismiss approval automatically (#25882) 2023-07-20 15:18:52 +08:00
pull_list.go Add context parameter to some database functions (#26055) 2023-07-22 22:14:27 +08:00
pull_test.go Add context parameter to some database functions (#26055) 2023-07-22 22:14:27 +08:00
reaction.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
reaction_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
review.go Fix bug when pushing to a pull request which enabled dismiss approval automatically (#25882) 2023-07-20 15:18:52 +08:00
review_list.go Add commits dropdown in PR files view and allow commit by commit review (#25528) 2023-07-28 21:18:12 +02:00
review_test.go Fix bug when pushing to a pull request which enabled dismiss approval automatically (#25882) 2023-07-20 15:18:52 +08:00
stopwatch.go Speed up HasUserStopwatch & GetActiveStopwatch (#23051) 2023-02-27 13:46:00 -05:00
stopwatch_test.go Speed up HasUserStopwatch & GetActiveStopwatch (#23051) 2023-02-27 13:46:00 -05:00
tracked_time.go Add context parameter to some database functions (#26055) 2023-07-22 22:14:27 +08:00
tracked_time_test.go Add context parameter to some database functions (#26055) 2023-07-22 22:14:27 +08:00