mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-11-22 08:42:32 -05:00
dd12384f22
* Fix --port setting Unfortunately there was an error in #13195 which set the --port option before the settings were read. This PR fixes this by moving applying this option to after the the settings are read However, on looking further into this code I believe that the setPort code was slightly odd. Firstly, it may make sense to run the install page on a different temporary port to the full system and this should be possible with a --install-port option. Secondy, if the --port option is provided we should apply it to both otherwise there will be unusual behaviour on graceful restart Thirdly, the documentation for --port says that the setting is temporary - it should therefore not save its result to the configuration (This however, does mean that authorized_keys and internal links may not be correct. - I think we need to discuss this option further.) Fix #13277 Signed-off-by: Andrew Thornton <art27@cantab.net> * Update cmd/web.go * Apply suggestions from code review Co-authored-by: techknowlogick <techknowlogick@gitea.io> |
||
|---|---|---|
| .. | ||
| admin.go | ||
| admin_auth_ldap.go | ||
| admin_auth_ldap_test.go | ||
| cert.go | ||
| cmd.go | ||
| convert.go | ||
| doctor.go | ||
| dump.go | ||
| embedded.go | ||
| embedded_stub.go | ||
| generate.go | ||
| hook.go | ||
| keys.go | ||
| mailer.go | ||
| manager.go | ||
| migrate.go | ||
| migrate_storage.go | ||
| serv.go | ||
| web.go | ||
| web_graceful.go | ||