mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-22 12:54:53 -05:00
9607750b5e
`hex.EncodeToString` has better performance than `fmt.Sprintf("%x",
[]byte)`, we should use it as much as possible.
I'm not an extreme fan of performance, so I think there are some
exceptions:
- `fmt.Sprintf("%x", func(...)[N]byte())`
- We can't slice the function return value directly, and it's not worth
adding lines.
```diff
func A()[20]byte { ... }
- a := fmt.Sprintf("%x", A())
- a := hex.EncodeToString(A()[:]) // invalid
+ tmp := A()
+ a := hex.EncodeToString(tmp[:])
```
- `fmt.Sprintf("%X", []byte)`
- `strings.ToUpper(hex.EncodeToString(bytes))` has even worse
performance.
|
||
|---|---|---|
| .. | ||
| composer | ||
| conan | ||
| container | ||
| helm | ||
| maven | ||
| npm | ||
| nuget | ||
| pub | ||
| pypi | ||
| rubygems | ||
| vagrant | ||
| content_store.go | ||
| hashed_buffer.go | ||
| hashed_buffer_test.go | ||
| multi_hasher.go | ||
| multi_hasher_test.go | ||