1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-23 12:59:11 -05:00
forgejo/routers/api
Earl Warren 6a555996dc
[GITEA] POST /repos/{owner}/{repo}/pulls/{index}/reviews/{id}/comments (squash) do not implicitly create a review
If a comment already exists in a review, the comment is added. If it
is the first comment added to a review, it will implicitly create a
new review instead of adding to the existing one.

The pull_service.CreateCodeComment function is responsibe for this
behavior and it will defer to createCodeComment once the review is
determined, either because it was found or because it was created.

Rename createCodeComment into CreateCodeCommentKnownReviewID to expose
it and change the API endpoint to use it instead. Since the review is
provided by the user and verified to exist already, there is no need
for the logic implemented by CreateCodeComment.

The tests are modified to remove the initial comment from the fixture
because it was creating the false positive. I was verified to fail
without this fix.
2024-01-18 11:09:05 +00:00
..
actions Refactor deletion (#28610) 2023-12-25 21:25:29 +01:00
forgejo/v1 [CLEANUP] Reuse ForgejoVersion variable 2024-01-15 14:48:04 +00:00
packages [GITEA] Drop sha256-simd in favor of stdlib 2024-01-15 16:11:57 +00:00
v1 [GITEA] POST /repos/{owner}/{repo}/pulls/{index}/reviews/{id}/comments (squash) do not implicitly create a review 2024-01-18 11:09:05 +00:00