1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-25 13:19:37 -05:00
forgejo/routers/api/v1/repo
Zettat123 6b74043b85
Fix missing signature key error when pulling Docker images with SERVE_DIRECT enabled (#32365)
Fix #28121

I did some tests and found that the `missing signature key` error is
caused by an incorrect `Content-Type` header. Gitea correctly sets the
`Content-Type` header when serving files.

348d1d0f32/routers/api/packages/container/container.go (L712-L717)
However, when `SERVE_DIRECT` is enabled, the `Content-Type` header may
be set to an incorrect value by the storage service. To fix this issue,
we can use query parameters to override response header values.

https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetObject.html
<img width="600px"
src="https://github.com/user-attachments/assets/f2ff90f0-f1df-46f9-9680-b8120222c555"
/>

In this PR, I introduced a new parameter to the `URL` method to support
additional parameters.

```
URL(path, name string, reqParams url.Values) (*url.URL, error)
```

---

Most S3-like services support specifying the content type when storing
objects. However, Gitea always use `application/octet-stream`.
Therefore, I believe we also need to improve the `Save` method to
support storing objects with the correct content type.

b7fb20e73e/modules/storage/minio.go (L214-L221)
(cherry picked from commit 0690cb076bf63f71988a709f62a9c04660b51a4f)

Conflicts:
	- modules/storage/azureblob.go
	  Dropped the change, as we do not support Azure blob storage.
	- modules/storage/helper.go
	  Resolved by adjusting their `discardStorage` to our
	  `DiscardStorage`
	- routers/api/actions/artifacts.go
	  routers/api/actions/artifactsv4.go
	  routers/web/repo/actions/view.go
	  routers/web/repo/download.go
	  Resolved the conflicts by manually adding the new `nil`
	  parameter to the `storage.Attachments.URL()` calls.

	  Originally conflicted due to differences in the if expression
	  above these calls.
2024-11-05 09:33:15 +01:00
..
action.go Set owner id to zero when GetRegistrationToken for repo (#31725) 2024-08-04 10:14:34 +02:00
avatar.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
blob.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
branch.go feat(quota): Quota enforcement 2024-08-02 11:10:34 +02:00
collaborators.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
commits.go Return 404 instead of error when commit not exist (#31977) 2024-09-09 20:54:47 +02:00
compare.go Enable unparam linter (#31277) 2024-06-16 13:42:58 +02:00
file.go Fix missing signature key error when pulling Docker images with SERVE_DIRECT enabled (#32365) 2024-11-05 09:33:15 +01:00
flags.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
fork.go chore(refactor): split repo_service.ForkRepository in two 2024-08-11 12:40:34 +02:00
git_hook.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
git_ref.go Add codespell support and fix a good number of typos with its help (#3270) 2024-05-09 13:49:37 +00:00
hook.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
hook_test.go [TESTS] Fix usage of LoadRepoCommit 2024-08-26 08:03:48 +02:00
issue.go API: enhance SearchIssues swagger docs (#32208) 2024-10-20 09:44:18 +02:00
issue_attachment.go feat(quota): Quota enforcement 2024-08-02 11:10:34 +02:00
issue_comment.go Load attachments for /issues/comments/{id} 2024-07-16 11:09:54 +02:00
issue_comment_attachment.go feat(quota): Quota enforcement 2024-08-02 11:10:34 +02:00
issue_dependency.go Fix missed doer (#30231) 2024-04-15 20:01:35 +02:00
issue_label.go Support using label names when changing issue labels (#30943) 2024-05-19 13:12:35 +02:00
issue_pin.go Fix missed doer (#30231) 2024-04-15 20:01:35 +02:00
issue_reaction.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
issue_stopwatch.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
issue_subscription.go Add codespell support and fix a good number of typos with its help (#3270) 2024-05-09 13:49:37 +00:00
issue_tracked_time.go Fix missed doer (#30231) 2024-04-15 20:01:35 +02:00
key.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
label.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
language.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
main_test.go make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
migrate.go feat(quota): Quota enforcement 2024-08-02 11:10:34 +02:00
milestone.go remove util.OptionalBool and related functions (#29513) 2024-03-06 12:10:46 +08:00
mirror.go [FIX] Don't allow SSH authentication without ssh executable 2024-08-26 08:58:35 +02:00
notes.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
patch.go feat(quota): Quota enforcement 2024-08-02 11:10:34 +02:00
pull.go Add branch auto deletion for scheduled PRs 2024-10-31 03:49:15 +01:00
pull_review.go Fix the logic of finding the latest pull review commit ID (#32139) 2024-10-06 07:44:28 +02:00
release.go feat: Add Search to Releases Page 2024-11-02 10:24:35 +01:00
release_attachment.go feat(quota): Quota enforcement 2024-08-02 11:10:34 +02:00
release_tags.go Protected tag is no internal server error (#30962) 2024-05-19 13:12:35 +02:00
repo.go refactor: remove redundant err declarations (#32381) 2024-11-05 09:33:15 +01:00
repo_test.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
star.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
status.go Cache repository default branch commit status to reduce query on commit status table (#29444) 2024-03-11 23:36:58 +07:00
subscriber.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
tag.go feat(quota): Quota enforcement 2024-08-02 11:10:34 +02:00
teams.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
topic.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
transfer.go feat(quota): Quota enforcement 2024-08-02 11:10:34 +02:00
tree.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
wiki.go feat(quota): Quota enforcement 2024-08-02 11:10:34 +02:00