mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-22 12:54:53 -05:00
716fcfcf72
A lot of our code is repeatedly testing if individual errors are specific types of Not Exist errors. This is repetitative and unnecesary. `Unwrap() error` provides a common way of labelling an error as a NotExist error and we can/should use this. This PR has chosen to use the common `io/fs` errors e.g. `fs.ErrNotExist` for our errors. This is in some ways not completely correct as these are not filesystem errors but it seems like a reasonable thing to do and would allow us to simplify a lot of our code to `errors.Is(err, fs.ErrNotExist)` instead of `package.IsErr...NotExist(err)` I am open to suggestions to use a different base error - perhaps `models/db.ErrNotExist` if that would be felt to be better. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: delvh <dev.lh@web.de> |
||
---|---|---|
.. | ||
install | ||
paginator | ||
common.go | ||
consistency.go | ||
context.go | ||
convert.go | ||
engine.go | ||
engine_test.go | ||
error.go | ||
index.go | ||
index_test.go | ||
iterate.go | ||
list_options.go | ||
log.go | ||
main_test.go | ||
name.go | ||
search.go | ||
sequence.go | ||
sql_postgres_with_schema.go |