mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-11-23 08:47:42 -05:00
6daf21c9b7
Fix #25451. Bugfixes: - When stopping the zombie or endless tasks, set `LogInStorage` to true after transferring the file to storage. It was missing, it could write to a nonexistent file in DBFS because `LogInStorage` was false. - Always update `ActionTask.Updated` when there's a new state reported by the runner, even if there's no change. This is to avoid the task being judged as a zombie task. Enhancement: - Support `Stat()` for DBFS file. - `WriteLogs` refuses to write if it could result in content holes. --------- Co-authored-by: Giteabot <teabot@gitea.io>
106 lines
3.1 KiB
Go
106 lines
3.1 KiB
Go
// Copyright 2022 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package actions
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"time"
|
|
|
|
actions_model "code.gitea.io/gitea/models/actions"
|
|
"code.gitea.io/gitea/models/db"
|
|
"code.gitea.io/gitea/modules/actions"
|
|
"code.gitea.io/gitea/modules/log"
|
|
"code.gitea.io/gitea/modules/timeutil"
|
|
)
|
|
|
|
const (
|
|
zombieTaskTimeout = 10 * time.Minute
|
|
endlessTaskTimeout = 3 * time.Hour
|
|
abandonedJobTimeout = 24 * time.Hour
|
|
)
|
|
|
|
// StopZombieTasks stops the task which have running status, but haven't been updated for a long time
|
|
func StopZombieTasks(ctx context.Context) error {
|
|
return stopTasks(ctx, actions_model.FindTaskOptions{
|
|
Status: actions_model.StatusRunning,
|
|
UpdatedBefore: timeutil.TimeStamp(time.Now().Add(-zombieTaskTimeout).Unix()),
|
|
})
|
|
}
|
|
|
|
// StopEndlessTasks stops the tasks which have running status and continuous updates, but don't end for a long time
|
|
func StopEndlessTasks(ctx context.Context) error {
|
|
return stopTasks(ctx, actions_model.FindTaskOptions{
|
|
Status: actions_model.StatusRunning,
|
|
StartedBefore: timeutil.TimeStamp(time.Now().Add(-endlessTaskTimeout).Unix()),
|
|
})
|
|
}
|
|
|
|
func stopTasks(ctx context.Context, opts actions_model.FindTaskOptions) error {
|
|
tasks, err := actions_model.FindTasks(ctx, opts)
|
|
if err != nil {
|
|
return fmt.Errorf("find tasks: %w", err)
|
|
}
|
|
|
|
jobs := make([]*actions_model.ActionRunJob, 0, len(tasks))
|
|
for _, task := range tasks {
|
|
if err := db.WithTx(ctx, func(ctx context.Context) error {
|
|
if err := actions_model.StopTask(ctx, task.ID, actions_model.StatusFailure); err != nil {
|
|
return err
|
|
}
|
|
if err := task.LoadJob(ctx); err != nil {
|
|
return err
|
|
}
|
|
jobs = append(jobs, task.Job)
|
|
return nil
|
|
}); err != nil {
|
|
log.Warn("Cannot stop task %v: %v", task.ID, err)
|
|
continue
|
|
}
|
|
|
|
remove, err := actions.TransferLogs(ctx, task.LogFilename)
|
|
if err != nil {
|
|
log.Warn("Cannot transfer logs of task %v: %v", task.ID, err)
|
|
continue
|
|
}
|
|
task.LogInStorage = true
|
|
if err := actions_model.UpdateTask(ctx, task, "log_in_storage"); err != nil {
|
|
log.Warn("Cannot update task %v: %v", task.ID, err)
|
|
continue
|
|
}
|
|
remove()
|
|
}
|
|
|
|
CreateCommitStatus(ctx, jobs...)
|
|
|
|
return nil
|
|
}
|
|
|
|
// CancelAbandonedJobs cancels the jobs which have waiting status, but haven't been picked by a runner for a long time
|
|
func CancelAbandonedJobs(ctx context.Context) error {
|
|
jobs, _, err := actions_model.FindRunJobs(ctx, actions_model.FindRunJobOptions{
|
|
Statuses: []actions_model.Status{actions_model.StatusWaiting, actions_model.StatusBlocked},
|
|
UpdatedBefore: timeutil.TimeStamp(time.Now().Add(-abandonedJobTimeout).Unix()),
|
|
})
|
|
if err != nil {
|
|
log.Warn("find abandoned tasks: %v", err)
|
|
return err
|
|
}
|
|
|
|
now := timeutil.TimeStampNow()
|
|
for _, job := range jobs {
|
|
job.Status = actions_model.StatusCancelled
|
|
job.Stopped = now
|
|
if err := db.WithTx(ctx, func(ctx context.Context) error {
|
|
_, err := actions_model.UpdateRunJob(ctx, job, nil, "status", "stopped")
|
|
return err
|
|
}); err != nil {
|
|
log.Warn("cancel abandoned job %v: %v", job.ID, err)
|
|
// go on
|
|
}
|
|
CreateCommitStatus(ctx, job)
|
|
}
|
|
|
|
return nil
|
|
}
|