mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-30 14:09:42 -05:00
8220e50b56
### Summary Extend the template variable substitution to replace file paths. This can be helpful for setting up log files & directories that should match the repository name. ### PR Changes - Move files matching glob pattern when setting up repos from template - For security, added ~escaping~ sanitization for cross-platform support and to prevent directory traversal (thanks @silverwind for the reference) - Added unit testing for escaping function - Fixed the integration tests for repo template generation by passing the repo_template_id - Updated the integration testfiles to add some variable substitution & assert the outputs I had to fix the existing repo template integration test and extend it to add a check for variable substitutions. Example: 
67 lines
1.6 KiB
Go
67 lines
1.6 KiB
Go
// Copyright 2019 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package repository
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
var giteaTemplate = []byte(`
|
|
# Header
|
|
|
|
# All .go files
|
|
**.go
|
|
|
|
# All text files in /text/
|
|
text/*.txt
|
|
|
|
# All files in modules folders
|
|
**/modules/*
|
|
`)
|
|
|
|
func TestGiteaTemplate(t *testing.T) {
|
|
gt := GiteaTemplate{Content: giteaTemplate}
|
|
assert.Len(t, gt.Globs(), 3)
|
|
|
|
tt := []struct {
|
|
Path string
|
|
Match bool
|
|
}{
|
|
{Path: "main.go", Match: true},
|
|
{Path: "a/b/c/d/e.go", Match: true},
|
|
{Path: "main.txt", Match: false},
|
|
{Path: "a/b.txt", Match: false},
|
|
{Path: "text/a.txt", Match: true},
|
|
{Path: "text/b.txt", Match: true},
|
|
{Path: "text/c.json", Match: false},
|
|
{Path: "a/b/c/modules/README.md", Match: true},
|
|
{Path: "a/b/c/modules/d/README.md", Match: false},
|
|
}
|
|
|
|
for _, tc := range tt {
|
|
t.Run(tc.Path, func(t *testing.T) {
|
|
match := false
|
|
for _, g := range gt.Globs() {
|
|
if g.Match(tc.Path) {
|
|
match = true
|
|
break
|
|
}
|
|
}
|
|
assert.Equal(t, tc.Match, match)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestFileNameSanitize(t *testing.T) {
|
|
assert.Equal(t, "test_CON", fileNameSanitize("test_CON"))
|
|
assert.Equal(t, "test CON", fileNameSanitize("test CON "))
|
|
assert.Equal(t, "__traverse__", fileNameSanitize("../traverse/.."))
|
|
assert.Equal(t, "http___localhost_3003_user_test.git", fileNameSanitize("http://localhost:3003/user/test.git"))
|
|
assert.Equal(t, "_", fileNameSanitize("CON"))
|
|
assert.Equal(t, "_", fileNameSanitize("con"))
|
|
assert.Equal(t, "_", fileNameSanitize("\u0000"))
|
|
assert.Equal(t, "目标", fileNameSanitize("目标"))
|
|
}
|