1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-11-25 08:59:31 -05:00
forgejo/services
Jason Song 9607750b5e
Replace fmt.Sprintf with hex.EncodeToString (#21960)
`hex.EncodeToString` has better performance than `fmt.Sprintf("%x",
[]byte)`, we should use it as much as possible.

I'm not an extreme fan of performance, so I think there are some
exceptions:

- `fmt.Sprintf("%x", func(...)[N]byte())`
- We can't slice the function return value directly, and it's not worth
adding lines.
    ```diff
    func A()[20]byte { ... }
    - a := fmt.Sprintf("%x", A())
    - a := hex.EncodeToString(A()[:]) // invalid
    + tmp := A()
    + a := hex.EncodeToString(tmp[:])
    ```
- `fmt.Sprintf("%X", []byte)`
- `strings.ToUpper(hex.EncodeToString(bytes))` has even worse
performance.
2022-11-28 11:19:18 +00:00
..
agit Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
asymkey Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
attachment Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
auth Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
automerge Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
comments Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
context Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
cron Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
externalaccount Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
forms Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
gitdiff Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
lfs Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
mailer Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
markup Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
migrations Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
mirror Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
org Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
packages Replace fmt.Sprintf with hex.EncodeToString (#21960) 2022-11-28 11:19:18 +00:00
pull Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
release Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repository Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
task Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
user Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
webhook Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
wiki Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00