1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-11-22 08:42:32 -05:00
forgejo/modules
zeripath 9dc53ba65f
Prevent panic in doctor command when running default checks (#21791) (#21808)
Backport #21791

There was a bug introduced in #21352 due to a change of behaviour caused
by #19280. This causes a panic on running the default doctor checks
because the panic introduced by #19280 assumes that the only way
opts.StdOut and opts.Stderr can be set in RunOpts is deliberately.
Unfortunately, when running a git.Command the provided RunOpts can be
set, therefore if you share a common set of RunOpts these two values can
be set by the previous commands.

This PR stops using common RunOpts for the commands in that doctor check
but secondly stops RunCommand variants from changing the provided
RunOpts.

Signed-off-by: Andrew Thornton <art27@cantab.net>
2022-11-13 22:43:40 +00:00
..
activitypub format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
analyze Simplify IsVendor (#19626) 2022-05-06 10:12:30 +01:00
appstate Sync git hooks when config file path changed (#21619) (#21625) 2022-10-30 11:16:09 +08:00
auth Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
avatar Use Go 1.19 fmt for Gitea 1.17, sync emoji data (#21239) 2022-09-22 21:58:31 +08:00
base Prettify number of issues (#17760) 2022-06-12 20:08:23 +08:00
cache Update go-chi/cache to utilize Ping() (#19719) 2022-05-15 20:43:27 +02:00
charset Detect truncated utf-8 characters at the end of content as still representing utf-8 (#19773) 2022-05-21 14:06:24 +01:00
container Move reaction to models/issues/ (#19264) 2022-03-31 17:20:39 +08:00
context Fix package access for admins and inactive users (#21580) (#21592) 2022-10-28 09:38:59 +08:00
convert Fix 500 on time in timeline API (#21052) (#21057) 2022-09-04 16:12:37 +01:00
csv Use Go 1.19 fmt for Gitea 1.17, sync emoji data (#21239) 2022-09-22 21:58:31 +08:00
doctor Prevent panic in doctor command when running default checks (#21791) (#21808) 2022-11-13 22:43:40 +00:00
emoji Use Go 1.19 fmt for Gitea 1.17, sync emoji data (#21239) 2022-09-22 21:58:31 +08:00
eventsource Stop spurious APIFormat stopwatches logs (#20008) 2022-06-17 22:47:15 +01:00
generate Use base32 for 2FA scratch token (#18384) 2022-01-26 12:10:10 +08:00
git Prevent panic in doctor command when running default checks (#21791) (#21808) 2022-11-13 22:43:40 +00:00
gitgraph improve code quality (#21464) (#21463) 2022-10-15 14:24:39 +02:00
graceful Ensure that graceful start-up is informed of unused SSH listener (#20877) 2022-08-21 20:18:22 +08:00
hcaptcha hCaptcha Support (#12594) 2020-10-02 23:37:53 -04:00
highlight Adjust line detection in highlight.go (#20612) 2022-08-03 01:37:28 +08:00
hostmatcher fix merge (#20819) 2022-08-17 11:33:26 -04:00
httpcache Add Cache-Control header to html and api responses, add no-transform (#20432) (#20459) 2022-07-23 11:58:58 +01:00
httplib refactor httplib (#18338) 2022-01-19 19:31:39 -05:00
indexer Fix dump-repo git init, fix wrong error type for NullDownloader (#20182) (#20186) 2022-07-01 18:01:05 +02:00
json Refactor legacy unknwon/com package, improve golangci lint (#19284) 2022-04-01 16:47:50 +08:00
lfs Move some code into models/git (#19879) 2022-06-12 23:51:54 +08:00
log Use Go 1.19 fmt for Gitea 1.17, sync emoji data (#21239) 2022-09-22 21:58:31 +08:00
markup Fix missing m.Run() in TestMain (#21341) 2022-10-05 12:17:16 +08:00
metrics format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
migration Add more checks in migration code (#21011) (#21050) 2022-09-04 08:41:21 -05:00
nosql fix broken insecureskipverify handling in rediss connection uris (#20967) (#21053) 2022-09-04 14:59:20 +01:00
notification Display total commit count in hook message (#21400) (#21481) 2022-10-17 10:37:44 -04:00
options Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
packages support binary deploy in npm packages (#21589) 2022-10-25 14:13:27 +08:00
paginator Remove legacy unmaintained packages, refactor to support change default locale (#19308) 2022-04-03 17:46:48 +08:00
password Fixed assert statements. (#16089) 2021-06-07 07:27:09 +02:00
pprof Use Go 1.19 fmt for Gitea 1.17, sync emoji data (#21239) 2022-09-22 21:58:31 +08:00
private Add Goroutine stack inspector to admin/monitor (#19207) 2022-03-31 19:01:43 +02:00
process Set Setpgid on child git processes (#19865) 2022-06-03 15:36:18 +01:00
proxy Return nil proxy function if proxy not enabled (#16742) 2021-08-19 16:41:20 -04:00
public Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
queue Fix 64-bit atomic operations on 32-bit machines (#19531) 2022-04-27 10:32:04 -05:00
recaptcha refactor: move from io/ioutil to io and os package (#17109) 2021-09-22 13:38:34 +08:00
references Custom regexp external issues (#17624) 2022-06-10 13:39:53 +08:00
regexplru Custom regexp external issues (#17624) 2022-06-10 13:39:53 +08:00
repository Use Go 1.19 fmt for Gitea 1.17, sync emoji data (#21239) 2022-09-22 21:58:31 +08:00
secret Use CryptoRandomBytes instead of CryptoRandomString (#18439) 2022-02-04 18:03:15 +01:00
session format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
setting Enable contenthash in filename for dynamic assets (#20813) (#20932) 2022-08-25 07:16:20 +01:00
ssh Ensure that graceful start-up is informed of unused SSH listener (#20877) 2022-08-21 20:18:22 +08:00
storage Add Package Registry (#16510) 2022-03-30 16:42:47 +08:00
structs Display total commit count in hook message (#21400) (#21481) 2022-10-17 10:37:44 -04:00
svg Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
sync Use queue instead of memory queue in webhook send service (#19390) 2022-04-25 20:03:01 +02:00
templates Fix generating compare link (#21519) (#21530) 2022-10-21 20:59:27 +08:00
test Move access and repo permission to models/perm/access (#19350) 2022-05-11 12:09:36 +02:00
timeutil Fix Timestamp.IsZero (#21593) (#21604) 2022-10-27 16:47:47 +08:00
translation Use en-US as fallback when using other default language (#21200) (#21256) 2022-09-25 22:14:57 +08:00
typesniffer Rework raw file http header logic (#20484) (#20542) 2022-07-30 18:37:02 +02:00
updatechecker format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
upload Simplify parameter types (#18006) 2021-12-20 04:41:31 +00:00
uri Prevent NPE if gitea uploader fails to open url (#18080) 2021-12-23 16:27:33 +00:00
user Add gitea-vet (#10948) 2020-04-05 07:20:50 +01:00
util Use Go 1.19 fmt for Gitea 1.17, sync emoji data (#21239) 2022-09-22 21:58:31 +08:00
validation Add more checks in migration code (#21011) (#21050) 2022-09-04 08:41:21 -05:00
web Unify repo settings & show better error (#19828) 2022-06-12 13:43:27 +08:00