1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-11-24 08:57:03 -05:00
forgejo/templates/repo/settings
silverwind a01387f5b1
Add form field id generation, remove duplicated ids (#30546)
Fixes: https://github.com/go-gitea/gitea/issues/30384

On repo settings page, there id `repo_name` was used 5 times on the same
page, some in modal and such. I think we are better off just
auto-generating these IDs in the future so that labels link up with
their form element.

Ideally this id generation would be done in backend in a subtemplate,
but seeing that we already have similar JS patches for checkboxes, I
took the easy path for now.

I also checked that these `#repo_name` were not in use in JS and the
only case where this id appears in JS is on the migration page where
it's still there.

---------

Co-authored-by: Giteabot <teabot@gitea.io>
(cherry picked from commit d4ec6b3d16496ce3b479d5a08f79823122dc2b7b)

Conflicts:
	- templates/repo/settings/options.tmpl
	  Conflict resolved by manually removing all `id` and `for`
	  attributes from elements that had `repo_name` as their id.
2024-04-22 08:09:00 +02:00
..
units Migrate margin and padding helpers to tailwind (#30043) 2024-03-30 07:17:29 +01:00
webhook move webhook/settings file around 2024-04-16 08:59:11 +02:00
actions.tmpl Support configuration variables on Gitea Actions (#24724) 2023-06-20 22:54:15 +00:00
branches.tmpl Migrate margin and padding helpers to tailwind (#30043) 2024-03-30 07:17:29 +01:00
collaboration.tmpl Fix incorrect tailwind migration (#30007) 2024-03-26 19:04:27 +01:00
deploy_keys.tmpl Migrate gt-hidden to tw-hidden (#30046) 2024-03-30 07:17:29 +01:00
githook_edit.tmpl Migrate gt-hidden to tw-hidden (#30046) 2024-03-30 07:17:29 +01:00
githooks.tmpl Migrate margin and padding helpers to tailwind (#30043) 2024-03-30 07:17:29 +01:00
layout_footer.tmpl Change to vertical navbar layout for secondary navbar for repo/user/admin settings (#24246) 2023-04-23 18:21:21 +08:00
layout_head.tmpl Use flex-container for repo and org settings (#27418) 2023-10-04 08:47:54 +02:00
lfs.tmpl [UI] Fix primary button background inconsistency 2024-04-03 19:52:36 +05:00
lfs_file.tmpl Migrate gt-hidden to tw-hidden (#30046) 2024-03-30 07:17:29 +01:00
lfs_file_find.tmpl Remove RenderEmojiPlain from template helper (#29375) 2024-02-26 22:30:27 +01:00
lfs_locks.tmpl Fix more "locale" usages (#27259) 2023-09-25 20:42:40 +08:00
lfs_pointers.tmpl Migrate font-family to tailwind (#30118) 2024-03-30 07:17:32 +01:00
navbar.tmpl Show more settings for empty repositories (#29130) 2024-02-14 21:44:24 +01:00
options.tmpl Add form field id generation, remove duplicated ids (#30546) 2024-04-22 08:09:00 +02:00
protected_branch.tmpl Merge pull request '[FEAT] Configure if protected branch rule should apply to admins' (#2867) from gusted/forgejo-protectedbranch-admins into forgejo 2024-04-01 19:28:29 +00:00
push_mirror_sync_modal.tmpl Always use ctx.Locale.Tr inside templates (#27231) 2023-09-25 08:56:50 +00:00
runner_edit.tmpl Change to vertical navbar layout for secondary navbar for repo/user/admin settings (#24246) 2023-04-23 18:21:21 +08:00
secrets.tmpl Change to vertical navbar layout for secondary navbar for repo/user/admin settings (#24246) 2023-04-23 18:21:21 +08:00
tags.tmpl Replace 10 more gt- classes with tw- (#29945) 2024-03-26 19:04:27 +01:00
units.tmpl Split out repository unit settings 2024-02-13 22:42:09 +01:00