mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-04 10:30:19 -05:00
7a004ad7eb
Backport #21831. The [labels in issue YAML templates](https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-issue-forms#top-level-syntax) can be a string array or a comma-delimited string, so a single string should be valid labels. The old codes committed in #20987 ignore this, that's why the warning is displayed: <img width="618" alt="image" src="https://user-images.githubusercontent.com/9418365/202112642-93dc72d0-71c3-40a2-9720-30fc2d48c97c.png"> Fixes #17877.
106 lines
2.1 KiB
Go
106 lines
2.1 KiB
Go
// Copyright 2022 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package structs
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"gopkg.in/yaml.v3"
|
|
)
|
|
|
|
func TestIssueTemplate_Type(t *testing.T) {
|
|
tests := []struct {
|
|
fileName string
|
|
want IssueTemplateType
|
|
}{
|
|
{
|
|
fileName: ".gitea/ISSUE_TEMPLATE/bug_report.yaml",
|
|
want: IssueTemplateTypeYaml,
|
|
},
|
|
{
|
|
fileName: ".gitea/ISSUE_TEMPLATE/bug_report.md",
|
|
want: IssueTemplateTypeMarkdown,
|
|
},
|
|
{
|
|
fileName: ".gitea/ISSUE_TEMPLATE/bug_report.txt",
|
|
want: "",
|
|
},
|
|
{
|
|
fileName: ".gitea/ISSUE_TEMPLATE/config.yaml",
|
|
want: "",
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.fileName, func(t *testing.T) {
|
|
it := IssueTemplate{
|
|
FileName: tt.fileName,
|
|
}
|
|
assert.Equal(t, tt.want, it.Type())
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestIssueTemplateLabels_UnmarshalYAML(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
content string
|
|
tmpl *IssueTemplate
|
|
want *IssueTemplate
|
|
wantErr string
|
|
}{
|
|
{
|
|
name: "array",
|
|
content: `labels: ["a", "b", "c"]`,
|
|
tmpl: &IssueTemplate{
|
|
Labels: []string{"should_be_overwrote"},
|
|
},
|
|
want: &IssueTemplate{
|
|
Labels: []string{"a", "b", "c"},
|
|
},
|
|
},
|
|
{
|
|
name: "string",
|
|
content: `labels: "a,b,c"`,
|
|
tmpl: &IssueTemplate{
|
|
Labels: []string{"should_be_overwrote"},
|
|
},
|
|
want: &IssueTemplate{
|
|
Labels: []string{"a", "b", "c"},
|
|
},
|
|
},
|
|
{
|
|
name: "empty",
|
|
content: `labels:`,
|
|
tmpl: &IssueTemplate{
|
|
Labels: []string{"should_be_overwrote"},
|
|
},
|
|
want: &IssueTemplate{
|
|
Labels: nil,
|
|
},
|
|
},
|
|
{
|
|
name: "error",
|
|
content: `
|
|
labels:
|
|
a: aa
|
|
b: bb
|
|
`,
|
|
tmpl: &IssueTemplate{},
|
|
wantErr: "line 3: cannot unmarshal !!map into IssueTemplateLabels",
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
err := yaml.Unmarshal([]byte(tt.content), tt.tmpl)
|
|
if tt.wantErr != "" {
|
|
assert.EqualError(t, err, tt.wantErr)
|
|
} else {
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, tt.want, tt.tmpl)
|
|
}
|
|
})
|
|
}
|
|
}
|