forgejo/release-notes/8.0.0/fix/3562.md at ad0b97c7c26072d3ddbf76c55c3edaab2f070a2b - foster/forgejo - Foster's Laboratory

foster/forgejo

mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-11-30 09:41:11 -05:00

Gergely Nagy 6f35a5ab90

Fix Issue watching / unwatching on the web ui

When subscribing or unsubscribing to/from an issue on the web ui, the
request was posted to a route handled by `repo.IssueWatch`. This
function used `ctx.Req.PostForm.Get()`, erroneously.

`request.PostForm` is *only* available if `request.ParseForm()` has been
called before it. The function in question did not do that. Under some
circumstances, something, somewhere did end up calling `ParseForm()`,
but not in every scenario.

Since we do not need to check for multiple values, the easiest fix here
is to use `ctx.Req.PostFormValue`, which will call `ParseForm()` if
necessary.

Fixes #3516.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>

2024-05-01 13:32:39 +02:00

1 line

128 B

Markdown

Raw Blame History

Fixed a bug where subscribing to or unsubscribing from an issue in a repository with no code produced an internal server error.