1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-11-29 09:31:11 -05:00
forgejo/modules/packages
Jason Song 9607750b5e
Replace fmt.Sprintf with hex.EncodeToString (#21960)
`hex.EncodeToString` has better performance than `fmt.Sprintf("%x",
[]byte)`, we should use it as much as possible.

I'm not an extreme fan of performance, so I think there are some
exceptions:

- `fmt.Sprintf("%x", func(...)[N]byte())`
- We can't slice the function return value directly, and it's not worth
adding lines.
    ```diff
    func A()[20]byte { ... }
    - a := fmt.Sprintf("%x", A())
    - a := hex.EncodeToString(A()[:]) // invalid
    + tmp := A()
    + a := hex.EncodeToString(tmp[:])
    ```
- `fmt.Sprintf("%X", []byte)`
- `strings.ToUpper(hex.EncodeToString(bytes))` has even worse
performance.
2022-11-28 11:19:18 +00:00
..
composer Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
conan Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
container Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
helm Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
maven Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
npm Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
nuget Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
pub Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
pypi Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
rubygems Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
vagrant Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
content_store.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
hashed_buffer.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
hashed_buffer_test.go Replace fmt.Sprintf with hex.EncodeToString (#21960) 2022-11-28 11:19:18 +00:00
multi_hasher.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
multi_hasher_test.go Replace fmt.Sprintf with hex.EncodeToString (#21960) 2022-11-28 11:19:18 +00:00