1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-11-23 08:47:42 -05:00
forgejo/templates/repo/editor
silverwind e24f651c86
Add template linting via djlint (#25212)
So I found this [linter](https://github.com/Riverside-Healthcare/djlint)
which features a mode for go templates, so I gave it a try and it did
find a number of valid issue, like unbalanced tags etc. It also has a
number of bugs, I had to disable/workaround many issues.

Given that this linter is written in python, this does add a dependency
on `python` >= 3.8 and `poetry` to the development environment to be
able to run this linter locally.

- `e.g.` prefixes on placeholders are removed because the linter had a
false-positive on `placeholder="e.g. cn=Search"` for the `attr=value`
syntax and it's not ideal anyways to write `e.g.` into a placeholder
because a placeholder is meant to hold a sample value.
- In `templates/repo/settings/options.tmpl` I simplified the logic to
not conditionally create opening tags without closing tags because this
stuff confuses the linter (and possibly the reader as well).
2023-06-14 18:17:58 +00:00
..
cherry_pick.tmpl Add template linting via djlint (#25212) 2023-06-14 18:17:58 +00:00
commit_form.tmpl Create pull request for base after editing file, if not enabled on fork (#24841) 2023-05-24 21:36:02 +00:00
delete.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
diff_preview.tmpl Fix broken code editor diff preview (#23307) 2023-03-06 09:37:58 +08:00
edit.tmpl Remove fomantic breadcrumb module (#24463) 2023-05-01 11:40:02 -04:00
patch.tmpl Add template linting via djlint (#25212) 2023-06-14 18:17:58 +00:00
upload.tmpl Remove fomantic breadcrumb module (#24463) 2023-05-01 11:40:02 -04:00