1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-23 12:59:11 -05:00
forgejo/routers/web/repo
Jason Song 1e76a824bc
Refactor and enhance issue indexer to support both searching, filtering and paging (#26012)
Fix #24662.

Replace #24822 and #25708 (although it has been merged)


## Background

In the past, Gitea supported issue searching with a keyword and
conditions in a less efficient way. It worked by searching for issues
with the keyword and obtaining limited IDs (as it is heavy to get all)
on the indexer (bleve/elasticsearch/meilisearch), and then querying with
conditions on the database to find a subset of the found IDs. This is
why the results could be incomplete.

To solve this issue, we need to store all fields that could be used as
conditions in the indexer and support both keyword and additional
conditions when searching with the indexer.

## Major changes

- Redefine `IndexerData` to include all fields that could be used as
filter conditions.
- Refactor `Search(ctx context.Context, kw string, repoIDs []int64,
limit, start int, state string)` to `Search(ctx context.Context, options
*SearchOptions)`, so it supports more conditions now.
- Change the data type stored in `issueIndexerQueue`. Use
`IndexerMetadata` instead of `IndexerData` in case the data has been
updated while it is in the queue. This also reduces the storage size of
the queue.
- Enhance searching with Bleve/Elasticsearch/Meilisearch, make them
fully support `SearchOptions`. Also, update the data versions.
- Keep most logic of database indexer, but remove
`issues.SearchIssueIDsByKeyword` in `models` to avoid confusion where is
the entry point to search issues.
- Start a Meilisearch instance to test it in unit tests.
- Add unit tests with almost full coverage to test
Bleve/Elasticsearch/Meilisearch indexer.

---------

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-07-31 06:28:53 +00:00
..
actions Implement auto-cancellation of concurrent jobs if the event is push (#25716) 2023-07-25 11:15:55 +08:00
setting Move web JSON functions to web context and simplify code (#26132) 2023-07-26 06:04:01 +00:00
activity.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
attachment.go Less naked returns (#25713) 2023-07-07 05:31:56 +00:00
blame.go Sort repo topic labels by name (#24123) 2023-04-14 15:29:05 -04:00
branch.go Move web JSON functions to web context and simplify code (#26132) 2023-07-26 06:04:01 +00:00
cherry_pick.go Sync branches into databases (#22743) 2023-06-29 10:03:20 +00:00
commit.go Fix pull request check list is limited (#26179) 2023-07-31 02:21:09 +00:00
compare.go Use frontend fetch for branch dropdown component (#25719) 2023-07-21 11:20:04 +00:00
download.go Less naked returns (#25713) 2023-07-07 05:31:56 +00:00
editor.go Refactor "Content" for file uploading (#25851) 2023-07-18 18:14:47 +00:00
editor_test.go Refactor web package and context package (#25298) 2023-06-18 09:59:09 +02:00
find.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
helper.go Add actor and status dropdowns to run list (#25118) 2023-06-21 04:25:14 +00:00
helper_test.go Add actor and status dropdowns to run list (#25118) 2023-06-21 04:25:14 +00:00
http.go Less naked returns (#25713) 2023-07-07 05:31:56 +00:00
http_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue.go Refactor and enhance issue indexer to support both searching, filtering and paging (#26012) 2023-07-31 06:28:53 +00:00
issue_content_history.go Check ctx.Written() for GetActionIssue (#25698) 2023-07-05 18:52:12 +00:00
issue_dependency.go Add context parameter to some database functions (#26055) 2023-07-22 22:14:27 +08:00
issue_label.go Move web JSON functions to web context and simplify code (#26132) 2023-07-26 06:04:01 +00:00
issue_label_test.go Refactor web package and context package (#25298) 2023-06-18 09:59:09 +02:00
issue_lock.go Use fetch form action for lock/unlock/pin/unpin on sidebar (#25380) 2023-06-29 04:16:04 +00:00
issue_pin.go Add context parameter to some database functions (#26055) 2023-07-22 22:14:27 +08:00
issue_stopwatch.go Speed up HasUserStopwatch & GetActiveStopwatch (#23051) 2023-02-27 13:46:00 -05:00
issue_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue_timetrack.go Add context parameter to some database functions (#26055) 2023-07-22 22:14:27 +08:00
issue_watch.go Rewrite logger system (#24726) 2023-05-21 22:35:11 +00:00
main_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
middlewares.go Show outdated comments in files changed tab (#24936) 2023-06-21 16:08:12 +00:00
migrate.go Make repo migration cancelable and fix various bugs (#24605) 2023-05-11 08:25:46 +00:00
milestone.go Move web JSON functions to web context and simplify code (#26132) 2023-07-26 06:04:01 +00:00
packages.go Use dynamic package type list (#22263) 2022-12-29 00:31:54 +01:00
patch.go Sync branches into databases (#22743) 2023-06-29 10:03:20 +00:00
projects.go Move web JSON functions to web context and simplify code (#26132) 2023-07-26 06:04:01 +00:00
projects_test.go Refactor web package and context package (#25298) 2023-06-18 09:59:09 +02:00
pull.go Fix pull request check list is limited (#26179) 2023-07-31 02:21:09 +00:00
pull_review.go Move web JSON functions to web context and simplify code (#26132) 2023-07-26 06:04:01 +00:00
release.go Move web JSON functions to web context and simplify code (#26132) 2023-07-26 06:04:01 +00:00
release_test.go Refactor web package and context package (#25298) 2023-06-18 09:59:09 +02:00
render.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repo.go Use frontend fetch for branch dropdown component (#25719) 2023-07-21 11:20:04 +00:00
search.go Refactor indexer (#25174) 2023-06-23 12:37:56 +00:00
topic.go Replace interface{} with any (#25686) 2023-07-04 18:36:08 +00:00
treelist.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
view.go Show image size on view page (#25884) 2023-07-31 05:04:45 +00:00
view_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
wiki.go Move web JSON functions to web context and simplify code (#26132) 2023-07-26 06:04:01 +00:00
wiki_test.go Replace interface{} with any (#25686) 2023-07-04 18:36:08 +00:00