1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-11-24 08:57:03 -05:00
forgejo/models
Gusted 0418c19287
[GITEA] Add slow SQL query warning
- Databases are one of the most important parts of Forgejo, every
interaction with Forgejo uses the database in one way or another.
Therefore, it is important to maintain the database and recognize when
Forgejo is not doing well with the database. Forgejo already has the
option to log *every* SQL query along with its execution time, but
monitoring becomes impractical for larger instances and takes up
unnecessary storage in the logs.
- Add a QoL enhancement that allows instance administrators to specify a
threshold value beyond which query execution time is logged as a warning
in the xorm logger. The default value is a conservative five seconds to
avoid this becoming a source of spam in the logs.
- The use case for this patch is that with an instance the size of Codeberg, monitoring SQL logs is not very fruitful and most of them are uninteresting. Recently, in the context of persistent deadlock issues (https://codeberg.org/forgejo/forgejo/issues/220), I have noticed that certain queries hold locks on tables like comment and issue for several seconds. This patch helps to identify which queries these are and when they happen.
- Added unit test.

(cherry picked from commit 24bbe7886f)
(cherry picked from commit 6e29145b3c)
(cherry picked from commit 63731e3071)
(cherry picked from commit 3ce1a09736)
(cherry picked from commit a64426907d)
(cherry picked from commit 4b19215691)
(cherry picked from commit e635674435)
(cherry picked from commit 9cf501f1af)
(cherry picked from commit 0d6b934eba)
(cherry picked from commit 4b6c273879)
(cherry picked from commit b50517139c)
(cherry picked from commit 6546dd1fc9)
(cherry picked from commit 3eda6890e6)

[GITEA] Add slow SQL query warning (squash) document the setting

(cherry picked from commit ce38599c51)
(cherry picked from commit 794aa67c68)
(cherry picked from commit 8227673deb)
(cherry picked from commit 8854d1d4dd)
(cherry picked from commit 9121a0e21f)
(cherry picked from commit 41bae2e425)
2023-11-13 14:04:16 +01:00
..
actions [CLI] implement forgejo-cli 2023-11-13 11:52:15 +01:00
activities Add Index to action.user_id (#27403) (#27425) 2023-10-04 08:53:00 +02:00
admin Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
asymkey Respect SSH.KeygenPath option when calculating ssh key fingerprints (#27536) (#27551) 2023-10-10 07:37:58 +00:00
auth [GITEA] silently ignore obsolete sudo scope 2023-11-13 14:04:15 +01:00
avatars Refactor system setting (#27000) (#27452) 2023-10-05 10:37:59 +00:00
db [GITEA] Add slow SQL query warning 2023-11-13 14:04:16 +01:00
dbfs Fix content holes in Actions task logs file (#25560) 2023-06-28 19:07:29 +02:00
fixtures [GITEA] Improve HTML title on repositories 2023-11-13 14:04:16 +01:00
forgejo/semver [UPGRADE] add sanity checks for [storage*] 2023-11-13 12:33:49 +01:00
forgejo_migrations [SEMVER] store SemVer in ForgejoSemVer after a database upgrade 2023-11-13 12:33:48 +01:00
git Upgrade xorm to 1.3.4 (#27807) (#27813) 2023-10-27 14:17:27 +02:00
issues [FEAT] allow setting the update date on issues and comments 2023-11-13 12:33:49 +01:00
migrations [UPGRADE] run sanity checks before the database is upgraded 2023-11-13 12:33:49 +01:00
organization Another round of db.DefaultContext refactor (#27103) (#27262) 2023-09-25 19:24:35 +02:00
packages move repository deletion to service layer (#26948) 2023-09-08 04:51:15 +00:00
perm move repository deletion to service layer (#26948) 2023-09-08 04:51:15 +00:00
project More db.DefaultContext refactor (#27265) (#27347) 2023-09-29 13:35:01 +00:00
pull refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
repo [GITEA] Improve HTML title on repositories 2023-11-13 14:04:16 +01:00
secret Refactor secrets modification logic (#26873) 2023-09-05 15:21:02 +00:00
shared/types Display owner of a runner as a tooltip instead of static text (#24377) 2023-05-12 08:43:27 +00:00
system Refactor system setting (#27000) (#27452) 2023-10-05 10:37:59 +00:00
unit Use Set[Type] instead of map[Type]bool/struct{}. (#26804) 2023-08-30 06:55:25 +00:00
unittest [TESTS] tests.AddFixtures helper loads additional per-test fixtures 2023-11-13 12:33:49 +01:00
user Refactor system setting (#27000) (#27452) 2023-10-05 10:37:59 +00:00
webhook Replace interface{} with any (#25686) 2023-07-04 18:36:08 +00:00
error.go Sync branches into databases (#22743) 2023-06-29 10:03:20 +00:00
fixture_generation.go Fix yaml test (#27297) (#27303) 2023-09-27 15:05:35 +08:00
fixture_test.go Fix yaml test (#27297) (#27303) 2023-09-27 15:05:35 +08:00
main_test.go move repository deletion to service layer (#26948) 2023-09-08 04:51:15 +00:00
org.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
org_team.go Use db.WithTx for AddTeamMember to avoid ctx abuse (#27095) 2023-09-16 12:54:23 +00:00
org_team_test.go Reduce usage of db.DefaultContext (#27073) 2023-09-14 17:09:32 +00:00
org_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repo.go Refactor system setting (#27000) (#27452) 2023-10-05 10:37:59 +00:00
repo_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repo_transfer.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
repo_transfer_test.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00