1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-22 12:54:53 -05:00
forgejo/templates/repo/diff
oliverpool 0fc61c8836 [BUG] split code conversations in diff tab (#2306)
Follow-up of #2282 and #2296 (which tried to address #2278)

One of the issue with the previous PR is that when a conversation on the Files tab was marked as "resolved", it would fetch all the comments for that line (even the outdated ones, which should not be shown on this page - except when explicitly activated).

To properly fix this, I have changed `FetchCodeCommentsByLine` to `FetchCodeConversation`. Its role is to fetch all comments related to a given (review, path, line) and reverted my changes in the template (which were based on a misunderstanding).

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2306
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: oliverpool <git@olivier.pfad.fr>
Co-committed-by: oliverpool <git@olivier.pfad.fr>
2024-02-16 12:16:11 +00:00
..
blob_excerpt.tmpl Fix more "locale" usages (#27259) 2023-09-25 20:42:40 +08:00
box.tmpl [GITEA] pulls: "Edit File" button in "Files Changed" tab 2024-02-05 16:09:42 +01:00
comment_form.tmpl Always use ctx.Locale.Tr inside templates (#27231) 2023-09-25 08:56:50 +00:00
comment_form_datahandler.tmpl Make sure fmt catches all templates (#20979) 2022-08-31 23:58:54 +08:00
comments.tmpl Fix default avatar image size in PR diff page (#28971) 2024-02-02 10:01:11 +00:00
compare.tmpl [GITEA] Fix misleading comparisons when comparing branches 2024-02-05 16:09:43 +01:00
conversation.tmpl Always use ctx.Locale.Tr inside templates (#27231) 2023-09-25 08:56:50 +00:00
conversations.tmpl [BUG] split code conversations in diff tab (#2306) 2024-02-16 12:16:11 +00:00
csv_diff.tmpl Fix CSV diff for added/deleted files (#21189) 2022-09-17 10:45:32 +08:00
escape_title.tmpl cleanup locale function usage (#27227) 2023-09-24 20:31:58 +00:00
image_diff.tmpl Replace ajax with fetch, improve image diff (#27267) 2023-10-11 12:34:21 +00:00
new_comment.tmpl Do not reload page after adding comments in Pull Request reviews (#13877) 2021-01-08 23:49:55 +02:00
new_review.tmpl Always use ctx.Locale.Tr inside templates (#27231) 2023-09-25 08:56:50 +00:00
options_dropdown.tmpl Always use ctx.Locale.Tr inside templates (#27231) 2023-09-25 08:56:50 +00:00
section_code.tmpl Add template linting via djlint (#25212) 2023-06-14 18:17:58 +00:00
section_split.tmpl [BUG] split code conversations in diff tab (#2306) 2024-02-16 12:16:11 +00:00
section_unified.tmpl [BUG] split code conversations in diff tab (#2306) 2024-02-16 12:16:11 +00:00
stats.tmpl Always use ctx.Locale.Tr inside templates (#27231) 2023-09-25 08:56:50 +00:00
whitespace_dropdown.tmpl Fix more "locale" usages (#27259) 2023-09-25 20:42:40 +08:00