1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-11-23 08:47:42 -05:00
forgejo/web_src/js
wxiaoguang 59d060622d
Improve RSS (#24335)
Follow  #22719

### Major changes

1. `ServerError` doesn't do format, so remove the `%s`
2. Simplify `RenderBranchFeed` (slightly)
3. Remove unused `BranchFeedRSS`
4. Make `feed.RenderBranchFeed` respect `EnableFeed` config
5. Make `RepoBranchTagSelector.vue` respect `EnableFeed` setting,
otherwise there is always RSS icon
6. The `(branchURLPrefix + item.url).replace('src', 'rss')` doesn't seem
right for all cases, for example, the string `src` could appear in
`branchURLPrefix`, so we need a separate `rssURLPrefix`
7. The `<a>` in Vue menu needs `@click.stop`, otherwise the menu itself
would be triggered at the same time
8. Change `<a><button></button></a>` to `<a role=button>`
9. Use `{{PathEscapeSegments .TreePath}}` instead of `{{range $i, $v :=
.TreeNames}}/{{$v}}{{end}}`


Screenshot of changed parts:

<details>


![image](https://user-images.githubusercontent.com/2114189/234315538-66603694-9093-48a8-af33-83575fd7a018.png)


![image](https://user-images.githubusercontent.com/2114189/234315786-f1efa60b-012e-490b-8ce2-d448dc6fe5c9.png)


![image](https://user-images.githubusercontent.com/2114189/234334941-446941bc-1baa-4256-8850-ccc439476cda.png)

</details>


### Other thoughts

Should we remove the RSS icon from the branch dropdown list? It seems
too complex for a list UI, and users already have the chance to get the
RSS feed URL from "branches" page.

---------

Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: silverwind <me@silverwind.io>
2023-04-25 22:53:44 -04:00
..
components Improve RSS (#24335) 2023-04-25 22:53:44 -04:00
features Refactor delete_modal_actions template and use it for project column related actions (#24097) 2023-04-23 17:24:19 +08:00
markup Fix math and mermaid rendering bugs (#24049) 2023-04-17 12:10:22 +02:00
modules Use 1.18's aria role for dropdown menus (#24144) 2023-04-16 21:58:22 +08:00
standalone Add new JS linter rules (#17699) 2021-11-22 16:19:01 +08:00
test Improve emoji and mention matching (#24255) 2023-04-22 11:32:34 -04:00
utils Improve emoji and mention matching (#24255) 2023-04-22 11:32:34 -04:00
webcomponents Refactor locale number (#24134) 2023-04-17 11:37:23 +08:00
bootstrap.js Show friendly 500 error page to users and developers (#24110) 2023-04-14 13:19:11 +08:00
index.js Use auto-updating, natively hoverable, localized time elements (#23988) 2023-04-11 01:01:20 +02:00
jquery.js Upgrade jQuery to 3.5.0, remove jQuery-Migrate, fix deprecations (#11055) 2020-04-18 18:46:29 -04:00
serviceworker.js Fix serviceworker output file and misc improvements (#11562) 2020-05-24 08:36:40 +01:00
svg.js Add RSS Feeds for branches and files (#22719) 2023-04-25 22:08:29 +08:00
svg.test.js Improve <SvgIcon> to make it output svg node and optimize performance (#23570) 2023-03-23 11:24:16 +08:00
utils.js Introduce GiteaLocaleNumber custom element to handle number localization on pages. (#23861) 2023-04-03 12:58:09 -04:00
utils.test.js Introduce GiteaLocaleNumber custom element to handle number localization on pages. (#23861) 2023-04-03 12:58:09 -04:00