mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-11-22 08:42:32 -05:00
e24f651c86
So I found this [linter](https://github.com/Riverside-Healthcare/djlint) which features a mode for go templates, so I gave it a try and it did find a number of valid issue, like unbalanced tags etc. It also has a number of bugs, I had to disable/workaround many issues. Given that this linter is written in python, this does add a dependency on `python` >= 3.8 and `poetry` to the development environment to be able to run this linter locally. - `e.g.` prefixes on placeholders are removed because the linter had a false-positive on `placeholder="e.g. cn=Search"` for the `attr=value` syntax and it's not ideal anyways to write `e.g.` into a placeholder because a placeholder is meant to hold a sample value. - In `templates/repo/settings/options.tmpl` I simplified the logic to not conditionally create opening tags without closing tags because this stuff confuses the linter (and possibly the reader as well). |
||
|---|---|---|
| .. | ||
| blob_excerpt.tmpl | ||
| box.tmpl | ||
| comment_form.tmpl | ||
| comment_form_datahandler.tmpl | ||
| comments.tmpl | ||
| compare.tmpl | ||
| conversation.tmpl | ||
| csv_diff.tmpl | ||
| escape_title.tmpl | ||
| image_diff.tmpl | ||
| new_comment.tmpl | ||
| new_review.tmpl | ||
| options_dropdown.tmpl | ||
| section_code.tmpl | ||
| section_split.tmpl | ||
| section_unified.tmpl | ||
| stats.tmpl | ||
| whitespace_dropdown.tmpl | ||