Earl Warren 603a44edf0 [GITEA] POST /repos/{owner}/{repo}/pulls/{index}/reviews/{id}/comments ... Refs: https://codeberg.org/forgejo/forgejo/issues/2109 (cherry picked from commit 8b4ba3dce7) (cherry picked from commit 196edea0f9) [GITEA] POST /repos/{owner}/{repo}/pulls/{index}/reviews/{id}/comments (squash) do not implicitly create a review If a comment already exists in a review, the comment is added. If it is the first comment added to a review, it will implicitly create a new review instead of adding to the existing one. The pull_service.CreateCodeComment function is responsibe for this behavior and it will defer to createCodeComment once the review is determined, either because it was found or because it was created. Rename createCodeComment into CreateCodeCommentKnownReviewID to expose it and change the API endpoint to use it instead. Since the review is provided by the user and verified to exist already, there is no need for the logic implemented by CreateCodeComment. The tests are modified to remove the initial comment from the fixture because it was creating the false positive. I was verified to fail without this fix. (cherry picked from commit 6a555996dc) (cherry picked from commit b173a0ccee) (cherry picked from commit 838ab9740a)		2024-02-05 16:09:42 +01:00
..
activity.go	Add activity feeds API (#23494)	2023-04-04 21:35:31 +08:00
activitypub.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
admin_user.go	chore(api): support ignore password if login source type is LDAP for creating user API (#28491)	2023-12-19 02:32:45 +00:00
attachment.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
commit_status.go	Restore warning commit status (#27504)	2023-10-08 22:16:06 +00:00
commit_status_test.go	refactor improve NoBetterThan (#26126)	2023-07-26 08:52:07 +00:00
cron.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
doc.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
fork.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
git_blob.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
git_hook.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
hook.go	[ACTIONS] on.schedule: create a new payload	2024-02-05 16:09:41 +01:00
issue.go	[FEAT] allow setting the update date on issues and comments	2024-02-05 14:44:33 +01:00
issue_comment.go	[FEAT] allow setting the update date on issues and comments	2024-02-05 14:44:33 +01:00
issue_label.go	[FEAT] allow setting the update date on issues and comments	2024-02-05 14:44:33 +01:00
issue_milestone.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
issue_reaction.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
issue_stopwatch.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
issue_test.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
issue_tracked_time.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
lfs_lock.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
mirror.go	Fix push mirror, wrong timestamp format (#27153)	2023-09-23 12:15:05 +00:00
miscellaneous.go	Add API for gitignore templates (#22783)	2023-04-27 11:51:20 +08:00
nodeinfo.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
notifications.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
org.go	Allow Organisations to have a E-Mail (#25082)	2023-07-25 08:26:27 +00:00
org_member.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
org_team.go	Doc update swagger doc for POST /orgs/{org}/teams (#26155)	2023-07-26 10:22:56 +00:00
package.go	Fix package webhook (#27839)	2023-10-31 04:43:38 +00:00
pull.go	Add the ability to pin Issues (#24406)	2023-05-25 15:17:19 +02:00
pull_review.go	[GITEA] POST /repos/{owner}/{repo}/pulls/{index}/reviews/{id}/comments	2024-02-05 16:09:42 +01:00
release.go	add Upload URL to release API (#26663)	2023-08-24 10:36:10 +00:00
repo.go	Add support for sha256 repositories (#23894)	2024-01-19 17:05:02 +01:00
repo_branch.go	Add branch protection setting for ignoring stale approvals (#28498)	2024-01-15 07:20:01 +00:00
repo_collaborator.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
repo_commit.go	Add file status for API "Get a single commit from a repository" (#16205) (#25831)	2023-07-20 16:35:47 +08:00
repo_file.go	Refactor "Content" for file uploading (#25851)	2023-07-18 18:14:47 +00:00
repo_flags.go	[FEAT] API support for repository flags	2024-02-05 16:09:42 +01:00
repo_key.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
repo_note.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
repo_refs.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
repo_tag.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
repo_topic.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
repo_tree.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
repo_watch.go	Replace interface{} with any (#25686)	2023-07-04 18:36:08 +00:00
repo_wiki.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
secret.go	refactor(API): refactor secret creation and update functionality (#26751)	2023-08-28 13:08:19 +08:00
settings.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
status.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
task.go	Make repo migration cancelable and fix various bugs (#24605)	2023-05-11 08:25:46 +00:00
user.go	Add API for changing Avatars (#25369)	2023-06-29 23:22:55 +00:00
user_app.go	Add scopes to API to create token and display them (#22989)	2023-02-20 15:28:44 -06:00
user_email.go	add admin API email endpoints (#22792)	2023-03-14 03:54:40 -04:00
user_gpgkey.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
user_key.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
visible_type.go	change org_type.go to visible_type.go and fix the notes (#22752)	2023-02-09 06:40:34 +00:00